You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/26 13:59:40 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #8012: Fix ElasticSearch implementation of `queryMetricsValues` and `readLabeledMetricsValues` doesn't fill default values

wu-sheng commented on a change in pull request #8012:
URL: https://github.com/apache/skywalking/pull/8012#discussion_r736574112



##########
File path: oap-server/server-starter/pom.xml
##########
@@ -29,7 +29,8 @@
     <artifactId>server-starter</artifactId>
 
     <properties>
-        <generateGitPropertiesFilename>${project.build.outputDirectory}/version.properties</generateGitPropertiesFilename>
+        <generateGitPropertiesFilename>${project.basedir}/src/main/resources/version.properties
+        </generateGitPropertiesFilename>

Review comment:
       @kezhenxu94 I moved the generated file into `resources` folder directly, then we would have to worry about the `build priority`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org