You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/09/18 11:15:30 UTC
[GitHub] zeppelin pull request #3180: [ZEPPELIN-3781] Bump up version of npm packages
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3180
[ZEPPELIN-3781] Bump up version of npm packages
### What is this PR for?
The goal of this PR is to track bump up version on babel, karma-coverage, protractor, and webpack-dev-server packages.
### What type of PR is it?
[Refactoring]
### What is the Jira issue?
* [ZEPPELIN-3781](https://issues.apache.org/jira/browse/ZEPPELIN-3781)
### How should this be tested?
CI shoud be green
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3781
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3180
----
commit 4e0c5fe8f4872b2308da570395a23eee04021c3c
Author: Prabhjyot Singh <pr...@...>
Date: 2018-09-18T11:12:52Z
ZEPPELIN-3781: Bump up version of npm packages
Change-Id: I5db4440cd0f980d97919aeef913a32849782559f
----
---
[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3180
Thanks @prabhjyotsingh LGTM
---
[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3180
oops, it seems a large change, not sure why node npm package upgrade needs so large change. I am not an frontend expert, just need some explanation. 😄
---
[GitHub] zeppelin pull request #3180: [ZEPPELIN-3781] Bump up version of npm packages
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3180
---
[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3180
CI green.
@zjffdu @felixcheung can you help review this.
---
[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3180
Changes consist of two files;
- The larger one being package-lock.json; It stores an exact, versioned dependency tree rather than using starred versioning like package.json itself (e.g. 1.0.*). This means you can guarantee the dependencies for other developers or prod releases, etc. It also has a mechanism to lock the tree but generally will regenerate if package.json changes. https://docs.npmjs.com/files/package-lock.json
- package.json contains the actual changes that needs upgrade.
---
[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3180
On second thought, this doesn't really require a backport.
---
[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3180
Sure, thanks for the review will merge this soon to both master and branch-0.8
---
[GitHub] zeppelin issue #3180: [ZEPPELIN-3781] Bump up version of npm packages
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3180
Is it necessary to backport to branch-0.8 ? Does it fix some critical issue ?
---