You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "pnoltes (via GitHub)" <gi...@apache.org> on 2023/06/28 17:47:43 UTC

[PR] Feature/442 export headers bundle libs (celix)

pnoltes opened a new pull request, #584:
URL: https://github.com/apache/celix/pull/584

   This PR adds the "hide symbols" configuration too most of the static libs in bundles/.
   Exception is rsa_commons, this gave issues with testing (error injection). 
   
   This PR solved the last part of #442 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Feature/442 export headers bundle libs (celix)

Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng merged PR #584:
URL: https://github.com/apache/celix/pull/584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Feature/442 export headers bundle libs (celix)

Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes commented on code in PR #584:
URL: https://github.com/apache/celix/pull/584#discussion_r1246339572


##########
libs/framework/CMakeLists.txt:
##########
@@ -66,6 +66,7 @@ install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/framewo
 install(DIRECTORY include_deprecated/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/framework COMPONENT framework)
 install(DIRECTORY ${CMAKE_BINARY_DIR}/celix/gen/includes/framework/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/framework COMPONENT framework)
 
+celix_target_hide_symbols(framework)

Review Comment:
   I think celix_target_hide_symbols is more explicit, but this was already done with the target properties (only for C visiblity, but most libs are only C). 
   
   See https://github.com/apache/celix/pull/584/files#diff-556b07494eb3b34b34072320fa4a8e72403f81725c9d7d7b35fc6e4243fd2b06R44
   
   This is also the case for utils, etcdlib, dfi.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Feature/442 export headers bundle libs (celix)

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #584:
URL: https://github.com/apache/celix/pull/584#issuecomment-1612358662

   ## [Codecov](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#584](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b711261) into [master](https://app.codecov.io/gh/apache/celix/commit/24d624ef6823bad55ca3a5dace4f453afbba26df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (24d624e) will **increase** coverage by `0.10%`.
   > The diff coverage is `59.48%`.
   
   > :exclamation: Current head b711261 differs from pull request most recent head 740fe55. Consider uploading reports for the commit 740fe55 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #584      +/-   ##
   ==========================================
   + Coverage   78.29%   78.40%   +0.10%     
   ==========================================
     Files         230      230              
     Lines       35013    34999      -14     
   ==========================================
   + Hits        27413    27440      +27     
   + Misses       7600     7559      -41     
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...e\_service\_admin\_dfi/src/remote\_service\_admin\_dfi.c](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvcmVtb3RlX3NlcnZpY2VfYWRtaW5fZGZpL3NyYy9yZW1vdGVfc2VydmljZV9hZG1pbl9kZmkuYw==) | `84.46% <ø> (-0.37%)` | :arrow_down: |
   | [...dles/remote\_services/rsa\_dfi\_utils/src/dfi\_utils.c](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvcnNhX2RmaV91dGlscy9zcmMvZGZpX3V0aWxzLmM=) | `84.14% <0.00%> (-2.11%)` | :arrow_down: |
   | [libs/dfi/src/avrobin\_serializer.c](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9kZmkvc3JjL2F2cm9iaW5fc2VyaWFsaXplci5j) | `60.37% <0.00%> (-0.05%)` | :arrow_down: |
   | [libs/dfi/src/dyn\_avpr\_function.c](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9kZmkvc3JjL2R5bl9hdnByX2Z1bmN0aW9uLmM=) | `64.88% <0.00%> (-0.44%)` | :arrow_down: |
   | [libs/dfi/src/dyn\_avpr\_interface.c](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9kZmkvc3JjL2R5bl9hdnByX2ludGVyZmFjZS5j) | `70.92% <0.00%> (-0.21%)` | :arrow_down: |
   | [libs/dfi/src/dyn\_common.c](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9kZmkvc3JjL2R5bl9jb21tb24uYw==) | `86.11% <ø> (-0.20%)` | :arrow_down: |
   | [libs/dfi/src/dyn\_type.c](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9kZmkvc3JjL2R5bl90eXBlLmM=) | `90.83% <0.00%> (-0.28%)` | :arrow_down: |
   | [libs/dfi/src/dyn\_type\_common.c](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9kZmkvc3JjL2R5bl90eXBlX2NvbW1vbi5j) | `92.85% <ø> (-0.48%)` | :arrow_down: |
   | [libs/dfi/src/json\_serializer.c](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGlicy9kZmkvc3JjL2pzb25fc2VyaWFsaXplci5j) | `82.83% <0.00%> (-0.26%)` | :arrow_down: |
   | [...te\_service\_admin\_dfi/src/export\_registration\_dfi.c](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvcmVtb3RlX3NlcnZpY2VfYWRtaW5fZGZpL3NyYy9leHBvcnRfcmVnaXN0cmF0aW9uX2RmaS5j) | `79.78% <25.00%> (-1.64%)` | :arrow_down: |
   | ... and [14 more](https://app.codecov.io/gh/apache/celix/pull/584?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/celix/pull/584/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Feature/442 export headers bundle libs (celix)

Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes commented on code in PR #584:
URL: https://github.com/apache/celix/pull/584#discussion_r1246337267


##########
bundles/remote_services/rsa_common/CMakeLists.txt:
##########
@@ -15,22 +15,31 @@
 # specific language governing permissions and limitations
 # under the License.
 
-add_library(rsa_common STATIC
-    src/endpoint_description.c
-    src/export_registration_impl.c
-    src/import_registration_impl.c
-    src/remote_interceptors_handler.c)
+set(RSA_COMMON_SRC
+        src/endpoint_description.c
+        src/export_registration_impl.c
+        src/import_registration_impl.c
+        src/remote_interceptors_handler.c
+        )
+
+add_library(rsa_common STATIC ${RSA_COMMON_SRC})
 set_target_properties(rsa_common PROPERTIES OUTPUT_NAME "celix_rsa_common")
 target_include_directories(rsa_common PRIVATE src)
 target_link_libraries(rsa_common PUBLIC Celix::framework Celix::c_rsa_spi Celix::log_helper)
 celix_deprecated_utils_headers(rsa_common)
 celix_deprecated_framework_headers(rsa_common)
+celix_target_hide_symbols(rsa_common)
 
 install(TARGETS rsa_common EXPORT celix COMPONENT rsa DESTINATION ${CMAKE_INSTALL_LIBDIR})
 
 #Setup target aliases to match external usage
 add_library(Celix::rsa_common ALIAS rsa_common)
 
 if (ENABLE_TESTING)
+    add_library(rsa_common_cut STATIC ${RSA_COMMON_SRC})

Review Comment:
   of course, this was missing a _cut library. 👍 , nice addition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Feature/442 export headers bundle libs (celix)

Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng commented on code in PR #584:
URL: https://github.com/apache/celix/pull/584#discussion_r1246351244


##########
libs/framework/CMakeLists.txt:
##########
@@ -66,6 +66,7 @@ install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/framewo
 install(DIRECTORY include_deprecated/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/framework COMPONENT framework)
 install(DIRECTORY ${CMAKE_BINARY_DIR}/celix/gen/includes/framework/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/celix/framework COMPONENT framework)
 
+celix_target_hide_symbols(framework)

Review Comment:
   Ouch! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org