[GitHub] [pinot] jugomezv commented on pull request #10418: Fix ramping delay caused by long lasting sequence of unfiltered messa…

["jugomezv (via GitHub)" <gi...@apache.org>]

jugomezv commented on PR #10418:
URL: https://github.com/apache/pinot/pull/10418#issuecomment-1512229539

   > My thinking was more towards my first comment. Both what is on master and this PR are not fundamentally right. But this version at least gives you true positives; if it says lag > 0, it is definitely > 0. I would argue that makes it more useful even in this intermediate state.
   > 
   > That said, my feelings aren't that strong, and I'm mostly commenting as an interested observer. If you're both comfortable with/prefer a completely separate patch, that's totally fine with me.
   
   Now that this change is merged, do you still observe the issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org