[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1792: DRILL-7250: Query with CTE fails when its name matches to the table name without access

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1792: DRILL-7250: Query with CTE fails when its name matches to the table name without access
URL: https://github.com/apache/drill/pull/1792#discussion_r285529985
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
 ##########
 @@ -280,12 +280,10 @@ protected void validateFrom(
             changeNamesIfTableIsTemporary(tempNode);
 
             // Check the schema and throw a valid SchemaNotFound exception instead of TableNotFound exception.
-            if (catalogReader.getTable(tempNode.names) == null) {
-              catalogReader.isValidSchema(tempNode.names);
-            }
+            catalogReader.isValidSchema(tempNode.names);
 
 Review comment:
   Names cannot be null?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services