You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Navina Ramesh <nr...@linkedin.com> on 2015/09/15 09:43:29 UTC

Review Request 38395: SAMZA-731: CoordinatorStream Equality not working

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38395/
-----------------------------------------------------------

Review request for samza, Yan Fang, Chris Riccomini, and Yi Pan (Data Infrastructure).


Bugs: SAMZA-731
    https://issues.apache.org/jira/browse/SAMZA-731


Repository: samza


Description
-------

SAMZA-731: CoordinatorStream Equality not working


Diffs
-----

  samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/CoordinatorStreamMessage.java 68e50a12eb0c7d5d66a11da48cc28c5b2dfa7b87 
  samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamMessage.java 60e2e5df65db5435c47ea525d85dee451279c798 

Diff: https://reviews.apache.org/r/38395/diff/


Testing
-------

./gradlew clean build
(Added a unit test)


Thanks,

Navina Ramesh


Re: Review Request 38395: SAMZA-731: CoordinatorStream Equality not working

Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38395/#review100024
-----------------------------------------------------------

Ship it!


Ship It!

- Yi Pan (Data Infrastructure)


On Sept. 15, 2015, 7:45 a.m., Navina Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38395/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 7:45 a.m.)
> 
> 
> Review request for samza, Yan Fang, Chris Riccomini, and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-731
>     https://issues.apache.org/jira/browse/SAMZA-731
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> SAMZA-731: CoordinatorStream Equality not working
> 
> 
> Diffs
> -----
> 
>   samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/CoordinatorStreamMessage.java 68e50a12eb0c7d5d66a11da48cc28c5b2dfa7b87 
>   samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamMessage.java 60e2e5df65db5435c47ea525d85dee451279c798 
> 
> Diff: https://reviews.apache.org/r/38395/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build
> (Added a unit test)
> 
> 
> Thanks,
> 
> Navina Ramesh
> 
>


Re: Review Request 38395: SAMZA-731: CoordinatorStream Equality not working

Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38395/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 7:45 a.m.)


Review request for samza, Yan Fang, Chris Riccomini, and Yi Pan (Data Infrastructure).


Changes
-------

Fixed white space


Bugs: SAMZA-731
    https://issues.apache.org/jira/browse/SAMZA-731


Repository: samza


Description
-------

SAMZA-731: CoordinatorStream Equality not working


Diffs (updated)
-----

  samza-core/src/main/java/org/apache/samza/coordinator/stream/messages/CoordinatorStreamMessage.java 68e50a12eb0c7d5d66a11da48cc28c5b2dfa7b87 
  samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamMessage.java 60e2e5df65db5435c47ea525d85dee451279c798 

Diff: https://reviews.apache.org/r/38395/diff/


Testing
-------

./gradlew clean build
(Added a unit test)


Thanks,

Navina Ramesh