You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/02 21:18:51 UTC
[GitHub] [incubator-superset] willbarrett opened a new pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
willbarrett opened a new pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Some Celery back-ends (AMQP for one) do not support forgetting tasks, as described here: https://github.com/apache/incubator-superset/issues/10757 - this PR wraps the call in a try/catch to avoid unnecessary pain on those back-ends.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-737291786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=h1) Report
> Merging [#10770](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=desc) (ff7136f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) (45f4c68) will **increase** coverage by `5.47%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
+ Coverage 61.11% 66.59% +5.47%
==========================================
Files 801 969 +168
Lines 37754 59066 +21312
Branches 3555 6283 +2728
==========================================
+ Hits 23075 39336 +16261
- Misses 14493 19478 +4985
- Partials 186 252 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.38% <ø> (+2.78%)` | :arrow_up: |
| python | `67.89% <100.00%> (+7.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `79.00% <100.00%> (+4.51%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `55.88% <0.00%> (-31.62%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `63.38% <0.00%> (-16.28%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `60.75% <0.00%> (-15.25%)` | :arrow_down: |
| [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `69.13% <0.00%> (-9.82%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `31.88% <0.00%> (-9.03%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `91.17% <0.00%> (-8.83%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `20.68% <0.00%> (-8.73%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `61.53% <0.00%> (-8.47%)` | :arrow_down: |
| ... and [490 more](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=footer). Last update [45f4c68...ff7136f](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-737291786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=h1) Report
> Merging [#10770](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=desc) (ff7136f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) (45f4c68) will **increase** coverage by `5.63%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
+ Coverage 61.11% 66.75% +5.63%
==========================================
Files 801 969 +168
Lines 37754 59066 +21312
Branches 3555 6283 +2728
==========================================
+ Hits 23075 39428 +16353
- Misses 14493 19386 +4893
- Partials 186 252 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.38% <ø> (+2.78%)` | :arrow_up: |
| python | `68.15% <100.00%> (+7.31%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `79.16% <100.00%> (+4.67%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `55.88% <0.00%> (-31.62%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `63.38% <0.00%> (-16.28%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `60.75% <0.00%> (-15.25%)` | :arrow_down: |
| [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `69.13% <0.00%> (-9.82%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `31.88% <0.00%> (-9.03%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `91.17% <0.00%> (-8.83%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `20.68% <0.00%> (-8.73%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `61.53% <0.00%> (-8.47%)` | :arrow_down: |
| ... and [490 more](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=footer). Last update [45f4c68...ff7136f](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-737291786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=h1) Report
> Merging [#10770](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=desc) (ff7136f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) (45f4c68) will **increase** coverage by `5.48%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
+ Coverage 61.11% 66.60% +5.48%
==========================================
Files 801 969 +168
Lines 37754 59066 +21312
Branches 3555 6283 +2728
==========================================
+ Hits 23075 39341 +16266
- Misses 14493 19473 +4980
- Partials 186 252 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.38% <ø> (+2.78%)` | :arrow_up: |
| python | `67.91% <100.00%> (+7.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `79.00% <100.00%> (+4.51%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `55.88% <0.00%> (-31.62%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `63.38% <0.00%> (-16.28%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `60.75% <0.00%> (-15.25%)` | :arrow_down: |
| [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `69.13% <0.00%> (-9.82%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `31.88% <0.00%> (-9.03%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `91.17% <0.00%> (-8.83%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `20.68% <0.00%> (-8.73%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `61.53% <0.00%> (-8.47%)` | :arrow_down: |
| ... and [490 more](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=footer). Last update [45f4c68...ff7136f](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-686048187
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=h1) Report
> Merging [#10770](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
- Coverage 61.11% 60.98% -0.14%
==========================================
Files 801 801
Lines 37754 37757 +3
Branches 3555 3555
==========================================
- Hits 23075 23026 -49
- Misses 14493 14545 +52
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.59% <ø> (ø)` | |
| #python | `60.62% <50.00%> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.38% <50.00%> (-0.11%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.08%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `94.18% <0.00%> (-4.07%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.43% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.05% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.58% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=footer). Last update [45f4c68...ff7136f](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-737291786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=h1) Report
> Merging [#10770](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=desc) (ff7136f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) (45f4c68) will **increase** coverage by `5.57%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
+ Coverage 61.11% 66.69% +5.57%
==========================================
Files 801 969 +168
Lines 37754 59066 +21312
Branches 3555 6283 +2728
==========================================
+ Hits 23075 39395 +16320
- Misses 14493 19419 +4926
- Partials 186 252 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.38% <ø> (+2.78%)` | :arrow_up: |
| python | `68.06% <100.00%> (+7.22%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `79.00% <100.00%> (+4.51%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `55.88% <0.00%> (-31.62%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `63.38% <0.00%> (-16.28%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `60.75% <0.00%> (-15.25%)` | :arrow_down: |
| [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `69.13% <0.00%> (-9.82%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `31.88% <0.00%> (-9.03%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `91.17% <0.00%> (-8.83%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `20.68% <0.00%> (-8.73%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `61.53% <0.00%> (-8.47%)` | :arrow_down: |
| ... and [490 more](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=footer). Last update [45f4c68...ff7136f](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-737291786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=h1) Report
> Merging [#10770](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=desc) (ff7136f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) (45f4c68) will **increase** coverage by `1.52%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
+ Coverage 61.11% 62.64% +1.52%
==========================================
Files 801 878 +77
Lines 37754 46639 +8885
Branches 3555 6283 +2728
==========================================
+ Hits 23075 29218 +6143
- Misses 14493 17169 +2676
- Partials 186 252 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.38% <ø> (+2.78%)` | :arrow_up: |
| python | `60.83% <50.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.38% <50.00%> (-0.11%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `55.88% <0.00%> (-31.62%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `63.38% <0.00%> (-16.28%)` | :arrow_down: |
| [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `69.13% <0.00%> (-9.82%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `31.88% <0.00%> (-9.03%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `20.68% <0.00%> (-8.73%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `61.53% <0.00%> (-8.47%)` | :arrow_down: |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `56.98% <0.00%> (-7.88%)` | :arrow_down: |
| [...et-frontend/src/components/Label/Label.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvTGFiZWwuc3Rvcmllcy50c3g=) | `75.00% <0.00%> (-6.82%)` | :arrow_down: |
| ... and [283 more](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=footer). Last update [45f4c68...ff7136f](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett merged pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-737291786
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=h1) Report
> Merging [#10770](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=desc) (ff7136f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) (45f4c68) will **increase** coverage by `5.62%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
+ Coverage 61.11% 66.74% +5.62%
==========================================
Files 801 969 +168
Lines 37754 59066 +21312
Branches 3555 6283 +2728
==========================================
+ Hits 23075 39422 +16347
- Misses 14493 19392 +4899
- Partials 186 252 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.38% <ø> (+2.78%)` | :arrow_up: |
| python | `68.13% <100.00%> (+7.29%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `79.00% <100.00%> (+4.51%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `55.88% <0.00%> (-31.62%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `63.38% <0.00%> (-16.28%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `60.75% <0.00%> (-15.25%)` | :arrow_down: |
| [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `69.13% <0.00%> (-9.82%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | `90.90% <0.00%> (-9.10%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `31.88% <0.00%> (-9.03%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `91.17% <0.00%> (-8.83%)` | :arrow_down: |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `20.68% <0.00%> (-8.73%)` | :arrow_down: |
| [...ontend/src/components/CertifiedIconWithTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbldpdGhUb29sdGlwLnRzeA==) | `61.53% <0.00%> (-8.47%)` | :arrow_down: |
| ... and [490 more](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=footer). Last update [45f4c68...ff7136f](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-686048187
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=h1) Report
> Merging [#10770](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
- Coverage 61.11% 60.98% -0.14%
==========================================
Files 801 801
Lines 37754 37757 +3
Branches 3555 3555
==========================================
- Hits 23075 23026 -49
- Misses 14493 14545 +52
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.59% <ø> (ø)` | |
| #python | `60.62% <50.00%> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.38% <50.00%> (-0.11%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.08%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `94.18% <0.00%> (-4.07%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.43% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.05% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.58% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=footer). Last update [45f4c68...ff7136f](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-734494785
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett closed pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
willbarrett closed pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10770: fix: Capture error when celery back-end does not support forgetting tasks
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10770:
URL: https://github.com/apache/incubator-superset/pull/10770#issuecomment-686048187
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=h1) Report
> Merging [#10770](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45f4c689a2ae1e56666c36340c4b27f9f05b5903?el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10770 +/- ##
==========================================
- Coverage 61.11% 61.00% -0.12%
==========================================
Files 801 801
Lines 37754 37757 +3
Branches 3555 3555
==========================================
- Hits 23075 23034 -41
- Misses 14493 14537 +44
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `61.59% <ø> (ø)` | |
| #python | `60.65% <50.00%> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.38% <50.00%> (-0.11%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.54% <0.00%> (-8.08%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.05% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.58% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=footer). Last update [45f4c68...ff7136f](https://codecov.io/gh/apache/incubator-superset/pull/10770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org