You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2019/07/01 21:09:29 UTC

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13768 )

Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95
......................................................................


Patch Set 1: Code-Review+2

Didn't look too much into the diff in squeasel files as they are mostly copy-and-paste from upstream I assume.

LGTM otherwise. Please fix the formatting nit in webserver.cc


-- 
To view, visit http://gerrit.cloudera.org:8080/13768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17f90561e0ea6b0917fff51b055225060a4fa549
Gerrit-Change-Number: 13768
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jul 2019 21:09:29 +0000
Gerrit-HasComments: No