You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2018/06/06 18:49:25 UTC
svn commit: r1833062 - in /tomcat/trunk:
java/org/apache/catalina/realm/JAASRealm.java webapps/docs/changelog.xml
Author: markt
Date: Wed Jun 6 18:49:25 2018
New Revision: 1833062
URL: http://svn.apache.org/viewvc?rev=1833062&view=rev
Log:
Make JAASRealm mis-configuration more obvious by requiring the authenticated Subject to include at least one Principal of a type specified by userClassNames
Modified:
tomcat/trunk/java/org/apache/catalina/realm/JAASRealm.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/realm/JAASRealm.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/JAASRealm.java?rev=1833062&r1=1833061&r2=1833062&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/realm/JAASRealm.java (original)
+++ tomcat/trunk/java/org/apache/catalina/realm/JAASRealm.java Wed Jun 6 18:49:25 2018
@@ -538,6 +538,7 @@ public class JAASRealm extends RealmBase
log.debug(sm.getString("jaasRealm.userPrincipalFailure"));
log.debug(sm.getString("jaasRealm.rolePrincipalFailure"));
}
+ return null;
} else {
if (roles.size() == 0) {
if (log.isDebugEnabled()) {
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1833062&r1=1833061&r2=1833062&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jun 6 18:49:25 2018
@@ -148,6 +148,11 @@
ensure that the correct Connector is removed when there are multiple
Connectors using different addresses but the same port. (markt)
</fix>
+ <fix>
+ Make <code>JAASRealm</code> mis-configuration more obvious by requiring
+ the authenticated Subject to include at least one Principal of a type
+ specified by <code>userClassNames</code>. (markt)
+ </fix>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org