[PR] sensor_rpmsg.c:Fix that "stub" will be created when local core only has subscribers. [nuttx]

["Otpvondoiats (via GitHub)" <gi...@apache.org>]

Otpvondoiats opened a new pull request, #13539:
URL: https://github.com/apache/nuttx/pull/13539

   ## Summary
   Bug fix, After the ap core subscribes to the 25hz batch 120ms data of the sensor core, it switches to the cp core and subscribes to the 50hz batch 120ms sensor core data. At this time, the data subscribed by the AP will be abnormally lost (12.5hz). Mainly because ap subscribes to sensor core data earlier than cp. The subscription of cp will be broadcast to the ap core at the same time, and the corresponding "path" already exists under "/dev/uorb" of ap. Thus the ap will create a "stub".
   There are some restrictions on the creation of "stub" to avoid this situation.
   ## Impact
   Cross-core communication and persistent topics
   ## Testing
   
   - build
   rpserver and rpproxy open uorb config
   ```
   ./build.sh nuttx/boards/sim/sim/sim/configs/rpserver -j16
   ./build.sh nuttx/boards/sim/sim/sim/configs/rpproxy -j16
   ```
   
   - order:
   1. rpserver 
   2. rpproxy
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] sensor_rpmsg.c:Fix that "stub" will be created when local core only has subscribers. [nuttx]

["lupyuen (via GitHub)" <gi...@apache.org>]

lupyuen commented on PR #13539:
URL: https://github.com/apache/nuttx/pull/13539#issuecomment-2360233958

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13494&type=pullrequests)
   
   **Yes, the PR generally meets the NuttX requirements, but could use some improvements:**
   
   **Strengths:**
   
   * **Summary:** Clearly describes the bug, its root cause, and the proposed fix.
   * **Impact:** Identifies the relevant areas affected (cross-core communication, persistent topics).
   * **Testing:**  Provides build environment details and test procedure.
   
   **Areas for Improvement:**
   
   * **Impact:** 
       * **User Impact:**  Will this fix change any user-facing behavior? Be explicit (YES/NO) and describe if necessary.
       * **Build Impact:** Be explicit (YES/NO). If YES, explain any required build process changes. 
       * **Hardware Impact:** Be explicit (YES/NO). If YES, specify affected architectures, boards, or drivers.
       * **Documentation Impact:**  Be explicit (YES/NO). If YES, clarify what documentation needs updating and whether it's included in the PR.
       * **Security Impact:**  Be explicit (YES/NO). Briefly explain any security implications.
       * **Compatibility Impact:** Be explicit (YES/NO) for backward, forward, and interoperability. Explain any potential issues.
   * **Testing:**
       * **Logs:**  The "before" and "after" logs are placeholders. Provide actual log snippets that demonstrate the bug and its resolution. This helps reviewers understand the impact and validate the fix.
   
   **Recommendations:**
   
   1. **Expand the "Impact" section** with explicit YES/NO answers and detailed descriptions where necessary.
   2. **Replace the placeholder logs** in the "Testing" section with real log output showing the problem before the fix and the correct behavior after.
   
   By addressing these points, you'll provide a comprehensive and informative PR that's easier for reviewers to assess and approve. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] sensor_rpmsg.c:Fix that "stub" will be created when local core only has subscribers. [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #13539:
URL: https://github.com/apache/nuttx/pull/13539


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org