[GitHub] [spark] viirya commented on a change in pull request #30824: [SPARK-33593][SQL] Parquet vector reader incorrect with binary partition value

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #30824:
URL: https://github.com/apache/spark/pull/30824#discussion_r545268193



##########
File path: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java
##########
@@ -54,6 +54,8 @@ public static void populate(WritableColumnVector col, InternalRow row, int field
     } else {
       if (t == DataTypes.BooleanType) {
         col.putBooleans(0, capacity, row.getBoolean(fieldIdx));
+      } else if (t == DataTypes.BinaryType) {
+        col.putByteArray(0, row.getBinary(fieldIdx));

Review comment:
       Hm? If there is no case for BinaryType, seems there is also no final `else` block, so it just leaves as unpopulate previously?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org