[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #3916: [Bug] Can not use non-key column as partition column in duplicate table

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #3916:
URL: https://github.com/apache/incubator-doris/pull/3916#discussion_r443184920



##########
File path: fe/src/main/java/org/apache/doris/analysis/RangePartitionDesc.java
##########
@@ -71,9 +72,12 @@ public void analyze(List<ColumnDef> columnDefs, Map<String, String> otherPropert
             boolean found = false;
             for (ColumnDef columnDef : columnDefs) {
                 if (columnDef.getName().equals(partitionCol)) {
-                    if (!columnDef.isKey()) {
+                    if (!columnDef.isKey() && columnDef.getAggregateType() != AggregateType.NONE) {
                         throw new AnalysisException("Only key column can be partition column");

Review comment:
       ```suggestion
                           throw new AnalysisException("The partition column could not be aggregated column");
   ```

##########
File path: fe/src/main/java/org/apache/doris/analysis/RangePartitionDesc.java
##########
@@ -145,9 +149,14 @@ public PartitionInfo toPartitionInfo(List<Column> schema, Map<String, Long> part
             boolean find = false;
             for (Column column : schema) {
                 if (column.getName().equalsIgnoreCase(colName)) {
-                    if (!column.isKey()) {
+                    if (!column.isKey() && column.getAggregationType() != AggregateType.NONE) {

Review comment:
       Why does it need a second check here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org