You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Herve Boutemy (JIRA)" <ji...@codehaus.org> on 2007/07/12 16:07:13 UTC
[jira] Created: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
-------------------------------------------------------------------------------------------------------
Key: DOXIA-133
URL: http://jira.codehaus.org/browse/DOXIA-133
Project: doxia
Issue Type: Bug
Components: Site Renderer
Affects Versions: 1.0-alpha-8
Reporter: Herve Boutemy
Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102847 ]
Herve Boutemy commented on DOXIA-133:
-------------------------------------
see http://docs.codehaus.org/display/MAVENUSER/XML+encoding for the roadmap to XML encoding support in Maven2
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104021 ]
Vincent Siveton commented on DOXIA-133:
---------------------------------------
Constants was implicit for me ;)
IMHO isXml() is too specific for an api.
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated DOXIA-133:
--------------------------------
Attachment: DOXIA-133_doxia-siterenderer.diff
DOXIA-133_doxia.diff
here are 2 patches to add XML encoding detection for contents that are defined in XML: xdoc, xhtml, docbook, fml
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: doxia
> Issue Type: Bug
> Components: Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vincent Siveton closed DOXIA-133.
---------------------------------
Assignee: Vincent Siveton
Resolution: Fixed
Patch applied with modifications discussed there.
Thanks again Herve.
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Assignee: Vincent Siveton
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated DOXIA-133:
--------------------------------
Component/s: Module - Xhtml
Module - Xdoc
Module - Fml
Module - Docbook Simple
Core
Patch Submitted: [Yes]
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated DOXIA-133:
--------------------------------
Fix Version/s: 1.0-alpha-9
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated DOXIA-133:
--------------------------------
Attachment: DOXIA-133_doxia.diff
patch reworked after the big refactoring in revision 562838.
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104019 ]
Herve Boutemy commented on DOXIA-133:
-------------------------------------
+1 on Doxia.getParser(String): Parser
-0 on Parser.getType():String
At least, there should be constants for "text" and "xml".
I prefer Parser.isXml() because getType() seems too open for me
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104032 ]
Herve Boutemy commented on DOXIA-133:
-------------------------------------
why not, today this attribute is used only for encoding algorithm selection, but it could be used more later: such a choice is more extensible
then go for it
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104318 ]
Herve Boutemy commented on DOXIA-133:
-------------------------------------
instead of String constants, why not use int constants, which would more clearly show that not any value can be used: each value has a precise meaning in the code
and the code could {{switch(parser.getType())}} instead of a suite of {{if (parser.getType().equals(Parser.TYPE_XML)) {} else if}}...
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated DOXIA-133:
--------------------------------
Attachment: (was: DOXIA-133_doxia.diff)
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated DOXIA-133:
--------------------------------
Attachment: DOXIA-133_doxia.diff
re-did the patch with latest trunk revision
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104017 ]
Vincent Siveton commented on DOXIA-133:
---------------------------------------
>From an API point of view, I am not at ease with Doxia.isXmlSource( String parserId ). I propose you a better approach which sounds better for me:
{code:title=Doxia.java|borderStyle=solid}
...
/**
* @param parserId Identifier for the parser to use.
* @return the parser defining for parserId.
* @throws ParserNotFoundException if no parser could be found
* for the given id.
*/
Parser getParser( String parserId )
throws ParserNotFoundException;
...
{code}
{code:title=Parser.java|borderStyle=solid}
...
/**
* @return xml for xml parser, text for text parser
*/
String getType();
...
{code}
{code:title=DefaultSiteRenderer.java|borderStyle=solid}
...
boolean isXml = doxia.getParser( renderingContext.getParserId() ).getType().equals("xml");
...
{code}
Thoughts?
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DOXIA-133) default XML encoding (UTF-8) or XML
encoding set in XML files is ignored: inputEncoding is used instead
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/DOXIA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated DOXIA-133:
--------------------------------
Attachment: DOXIA-133_doxia.diff
> default XML encoding (UTF-8) or XML encoding set in XML files is ignored: inputEncoding is used instead
> -------------------------------------------------------------------------------------------------------
>
> Key: DOXIA-133
> URL: http://jira.codehaus.org/browse/DOXIA-133
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core, Module - Docbook Simple, Module - Fml, Module - Xdoc, Module - Xhtml, Site Renderer
> Affects Versions: 1.0-alpha-8
> Reporter: Herve Boutemy
> Fix For: 1.0-alpha-9
>
> Attachments: DOXIA-133_doxia-siterenderer.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff, DOXIA-133_doxia.diff
>
>
> Encoding can be specified per file, in the XML header: <?xml version="1.0" encoding="xxx"?>, or defaults to UTF-8
> But DefaultSiteRenderer class always read files with inputEncoding: {{reader = new InputStreamReader( new FileInputStream( fullPathDoc ), context.getInputEncoding() );}}
> When the source file is XML (xdoc, xhtml), should use XmlReader from PLXUTILS-11 to detect the XML stream encoding instead.
> Test case included in MSITE-239, site-plugin-test14
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira