You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2014/07/20 22:05:05 UTC
git commit: [SPARK-2495][MLLIB] remove private[mllib] from linear
models' constructors
Repository: spark
Updated Branches:
refs/heads/master fa51b0fb5 -> 1b10b8114
[SPARK-2495][MLLIB] remove private[mllib] from linear models' constructors
This is part of SPARK-2495 to allow users construct linear models manually.
Author: Xiangrui Meng <me...@databricks.com>
Closes #1492 from mengxr/public-constructor and squashes the following commits:
a48b766 [Xiangrui Meng] remove private[mllib] from linear models' constructors
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/1b10b811
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/1b10b811
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/1b10b811
Branch: refs/heads/master
Commit: 1b10b8114a396f94fc82b0f3af1a5f66dfa0945d
Parents: fa51b0f
Author: Xiangrui Meng <me...@databricks.com>
Authored: Sun Jul 20 13:04:59 2014 -0700
Committer: Reynold Xin <rx...@apache.org>
Committed: Sun Jul 20 13:04:59 2014 -0700
----------------------------------------------------------------------
.../org/apache/spark/mllib/classification/LogisticRegression.scala | 2 +-
.../src/main/scala/org/apache/spark/mllib/classification/SVM.scala | 2 +-
mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala | 2 +-
.../scala/org/apache/spark/mllib/regression/LinearRegression.scala | 2 +-
.../scala/org/apache/spark/mllib/regression/RidgeRegression.scala | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/1b10b811/mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala b/mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
index 90aa8ac..2242329 100644
--- a/mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
+++ b/mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
@@ -30,7 +30,7 @@ import org.apache.spark.rdd.RDD
* @param weights Weights computed for every feature.
* @param intercept Intercept computed for this model.
*/
-class LogisticRegressionModel private[mllib] (
+class LogisticRegressionModel (
override val weights: Vector,
override val intercept: Double)
extends GeneralizedLinearModel(weights, intercept) with ClassificationModel with Serializable {
http://git-wip-us.apache.org/repos/asf/spark/blob/1b10b811/mllib/src/main/scala/org/apache/spark/mllib/classification/SVM.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/classification/SVM.scala b/mllib/src/main/scala/org/apache/spark/mllib/classification/SVM.scala
index 316ecd7..80f8a1b 100644
--- a/mllib/src/main/scala/org/apache/spark/mllib/classification/SVM.scala
+++ b/mllib/src/main/scala/org/apache/spark/mllib/classification/SVM.scala
@@ -30,7 +30,7 @@ import org.apache.spark.rdd.RDD
* @param weights Weights computed for every feature.
* @param intercept Intercept computed for this model.
*/
-class SVMModel private[mllib] (
+class SVMModel (
override val weights: Vector,
override val intercept: Double)
extends GeneralizedLinearModel(weights, intercept) with ClassificationModel with Serializable {
http://git-wip-us.apache.org/repos/asf/spark/blob/1b10b811/mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala b/mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala
index a05dfc0..cb0d39e 100644
--- a/mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala
+++ b/mllib/src/main/scala/org/apache/spark/mllib/regression/Lasso.scala
@@ -28,7 +28,7 @@ import org.apache.spark.rdd.RDD
* @param weights Weights computed for every feature.
* @param intercept Intercept computed for this model.
*/
-class LassoModel private[mllib] (
+class LassoModel (
override val weights: Vector,
override val intercept: Double)
extends GeneralizedLinearModel(weights, intercept)
http://git-wip-us.apache.org/repos/asf/spark/blob/1b10b811/mllib/src/main/scala/org/apache/spark/mllib/regression/LinearRegression.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/regression/LinearRegression.scala b/mllib/src/main/scala/org/apache/spark/mllib/regression/LinearRegression.scala
index 0ebad4e..8c078ec 100644
--- a/mllib/src/main/scala/org/apache/spark/mllib/regression/LinearRegression.scala
+++ b/mllib/src/main/scala/org/apache/spark/mllib/regression/LinearRegression.scala
@@ -27,7 +27,7 @@ import org.apache.spark.mllib.optimization._
* @param weights Weights computed for every feature.
* @param intercept Intercept computed for this model.
*/
-class LinearRegressionModel private[mllib] (
+class LinearRegressionModel (
override val weights: Vector,
override val intercept: Double)
extends GeneralizedLinearModel(weights, intercept) with RegressionModel with Serializable {
http://git-wip-us.apache.org/repos/asf/spark/blob/1b10b811/mllib/src/main/scala/org/apache/spark/mllib/regression/RidgeRegression.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/regression/RidgeRegression.scala b/mllib/src/main/scala/org/apache/spark/mllib/regression/RidgeRegression.scala
index bd983ba..a826deb 100644
--- a/mllib/src/main/scala/org/apache/spark/mllib/regression/RidgeRegression.scala
+++ b/mllib/src/main/scala/org/apache/spark/mllib/regression/RidgeRegression.scala
@@ -28,7 +28,7 @@ import org.apache.spark.mllib.linalg.Vector
* @param weights Weights computed for every feature.
* @param intercept Intercept computed for this model.
*/
-class RidgeRegressionModel private[mllib] (
+class RidgeRegressionModel (
override val weights: Vector,
override val intercept: Double)
extends GeneralizedLinearModel(weights, intercept)