You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/03/26 01:52:35 UTC

[GitHub] [incubator-skywalking] wu-sheng opened a new pull request #2403: Support endpoint group in mesh.

wu-sheng opened a new pull request #2403: Support endpoint group in mesh.
URL: https://github.com/apache/incubator-skywalking/pull/2403
 
 
   I am using the regex to group mesh, because this is what is common and JVM provided. Maybe we could re-write the algorithm, but later.
   
   Here the benchmark for 2 rules and 100 rules.
   ```
        * # JMH version: 1.21
        * # VM version: JDK 1.8.0_91, Java HotSpot(TM) 64-Bit Server VM, 25.91-b14
        * # VM invoker: /Users/wusheng/Documents/applications/jdk1.8.0_91.jdk/Contents/Home/jre/bin/java
        * # VM options: -ea -Didea.test.cyclic.buffer.size=1048576 -javaagent:/Applications/IntelliJ IDEA.app/Contents/lib/idea_rt.jar=54841:/Applications/IntelliJ IDEA.app/Contents/bin -Dfile.encoding=UTF-8
        * # Warmup: <none>
        * # Measurement: 5 iterations, 10 s each
        * # Timeout: 10 min per iteration
        * # Threads: 1 thread, will synchronize iterations
        * # Benchmark mode: Throughput, ops/time
        * # Benchmark: org.apache.skywalking.apm.util.StringFormatGroupTest.test100Rule
        *
        * # Run progress: 0.00% complete, ETA 00:01:40
        * # Fork: 1 of 1
        * Iteration   1: 32016.496 ops/s
        * Iteration   2: 36703.873 ops/s
        * Iteration   3: 37121.543 ops/s
        * Iteration   4: 36898.225 ops/s
        * Iteration   5: 34712.564 ops/s
        *
        *
        * Result "org.apache.skywalking.apm.util.StringFormatGroupTest.test100Rule":
        *   35490.540 ±(99.9%) 8345.368 ops/s [Average]
        *   (min, avg, max) = (32016.496, 35490.540, 37121.543), stdev = 2167.265
        *   CI (99.9%): [27145.173, 43835.908] (assumes normal distribution)
        *
        *
        * # JMH version: 1.21
        * # VM version: JDK 1.8.0_91, Java HotSpot(TM) 64-Bit Server VM, 25.91-b14
        * # VM invoker: /Users/wusheng/Documents/applications/jdk1.8.0_91.jdk/Contents/Home/jre/bin/java
        * # VM options: -ea -Didea.test.cyclic.buffer.size=1048576 -javaagent:/Applications/IntelliJ IDEA.app/Contents/lib/idea_rt.jar=54841:/Applications/IntelliJ IDEA.app/Contents/bin -Dfile.encoding=UTF-8
        * # Warmup: <none>
        * # Measurement: 5 iterations, 10 s each
        * # Timeout: 10 min per iteration
        * # Threads: 1 thread, will synchronize iterations
        * # Benchmark mode: Throughput, ops/time
        * # Benchmark: org.apache.skywalking.apm.util.StringFormatGroupTest.testMatch
        *
        * # Run progress: 50.00% complete, ETA 00:00:50
        * # Fork: 1 of 1
        * Iteration   1: 1137158.205 ops/s
        * Iteration   2: 1192936.161 ops/s
        * Iteration   3: 1218773.403 ops/s
        * Iteration   4: 1222966.452 ops/s
        * Iteration   5: 1235609.354 ops/s
        *
        *
        * Result "org.apache.skywalking.apm.util.StringFormatGroupTest.testMatch":
        *   1201488.715 ±(99.9%) 150813.461 ops/s [Average]
        *   (min, avg, max) = (1137158.205, 1201488.715, 1235609.354), stdev = 39165.777
        *   CI (99.9%): [1050675.254, 1352302.176] (assumes normal distribution)
        *
        *
        * # Run complete. Total time: 00:01:41
        *
        * REMEMBER: The numbers below are just data. To gain reusable insights, you need to follow up on
        * why the numbers are the way they are. Use profilers (see -prof, -lprof), design factorial
        * experiments, perform baseline and negative tests that provide experimental control, make sure
        * the benchmarking environment is safe on JVM/OS/HW level, ask for reviews from the domain experts.
        * Do not assume the numbers tell you what you want them to tell.
        *
        * Benchmark                           Mode  Cnt        Score        Error  Units
        * StringFormatGroupTest.test100Rule  thrpt    5    35490.540 ±   8345.368  ops/s
        * StringFormatGroupTest.testMatch    thrpt    5  1201488.715 ± 150813.461  ops/s
   ```
   
   This is totally optional, if we add `endpoint_rules.properties` in config folder, this active.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services