You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/08/18 16:59:47 UTC

[GitHub] [hadoop] BilwaST commented on pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable

BilwaST commented on pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228#issuecomment-675597847


   Thanks @zhengbli for patch. Overall patch looks good me. Just a minor nit.
   can you add a comment in below code which you removed?
   `
   if (!excludeFullNodes || !cNode.isQueueFull()) {
             retList.add(cNode);`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org