You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/09 13:09:57 UTC

[GitHub] [spark] srowen commented on a change in pull request #26773: [SPARK-30126][CORE]sparkContext.addFile and sparkContext.addJar fails when file path contains spaces

srowen commented on a change in pull request #26773: [SPARK-30126][CORE]sparkContext.addFile and sparkContext.addJar fails when file path contains spaces
URL: https://github.com/apache/spark/pull/26773#discussion_r355438561
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/SparkContextSuite.scala
 ##########
 @@ -294,6 +322,20 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu
     }
   }
 
+  test("add jar when path contains spaces") {
+    withTempDir { dir =>
+      val sep = File.separator
+      val tmpDir = Utils.createTempDir(dir.getAbsolutePath + sep + "test space")
+      val tmpJar = File.createTempFile("test", ".jar", tmpDir)
 
 Review comment:
   What is the issue with listJars() output there?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org