You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by traboukos <gi...@git.apache.org> on 2014/10/03 18:48:09 UTC

[GitHub] cordova-plugin-contacts pull request: Fix native add contacts ui

GitHub user traboukos opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/47

    Fix native add contacts ui

    This broke on iOS 7 since ABNewPersonViewController cannot be subclassed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grgmo/cordova-plugin-contacts ds_fix_native_add_contact_ui

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #47
    
----
commit e120fed1889f1843784c75f312294f96843dcc66
Author: grgmo <pg...@kentforlife.net>
Date:   2014-07-01T14:26:48Z

    get socialProfiles, all ims and phoneNumbers
    
    add socialProfiles
    
    missing ||
    
    messanger typo

commit 2b831ad209df3aa55289bf28e7829e884b6564f0
Author: grgmo <pg...@kentforlife.net>
Date:   2014-07-01T14:26:48Z

    get socialProfiles, all ims and phoneNumbers
    
    add socialProfiles
    
    missing ||
    
    messanger typo

commit ec367bdb2cb9c7da5c474cbb74de6cf10e244dc5
Author: grgmo <pg...@kentforlife.net>
Date:   2014-09-30T09:24:53Z

    update repo and fix conflicts

commit a2dacc9d875385bc8cc5eeb3d3739dae814b9690
Author: Dimitris Stefanidis <ds...@gmail.com>
Date:   2014-10-03T16:28:15Z

    Fix native add contact ui that was not working on iOS 7.0 and later

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: Fix native add contacts ui

Posted by traboukos <gi...@git.apache.org>.
Github user traboukos closed the pull request at:

    https://github.com/apache/cordova-plugin-contacts/pull/47


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org