You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/28 23:16:12 UTC

[GitHub] [tvm] ganler commented on a diff in pull request #11174: [fix] vec * mat in matmul in onnx converter

ganler commented on code in PR #11174:
URL: https://github.com/apache/tvm/pull/11174#discussion_r861374363


##########
python/tvm/relay/frontend/onnx.py:
##########
@@ -324,6 +324,9 @@ def flatten_to_nd(x, x_shape, nd=3):
             0,
         )
         return _op.reshape(output, fold_constant(final_shape))
+    elif a_rank == 1:
+        return _op.multiply(inputs[0], inputs[1])

Review Comment:
   Yes, this is also valid in ONNX standard. Both PyTorch and ONNXRuntime can pass it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org