You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/06 20:02:42 UTC
[GitHub] kaxil commented on a change in pull request #4362: [AIRFLOW-3559]
Add missing options to DatadogHook.
kaxil commented on a change in pull request #4362: [AIRFLOW-3559] Add missing options to DatadogHook.
URL: https://github.com/apache/airflow/pull/4362#discussion_r245520403
##########
File path: airflow/contrib/hooks/datadog_hook.py
##########
@@ -47,26 +47,15 @@ def __init__(self, datadog_conn_id='datadog_default'):
# for all metric submissions.
self.host = conn.host
- if self.api_key is None:
- raise AirflowException("api_key must be specified in the "
- "Datadog connection details")
- if self.app_key is None:
- raise AirflowException("app_key must be specified in the "
- "Datadog connection details")
Review comment:
In absence of this code block when a user forgets to have `api_key` in Connection extras, it won't give a useful error. Any reasoning behind removing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services