You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ponymail.apache.org by se...@apache.org on 2016/12/19 21:04:14 UTC
incubator-ponymail git commit: unhelpful error reporting for invalid
Permalinks/Source links
Repository: incubator-ponymail
Updated Branches:
refs/heads/master 5d09ac1c6 -> b8b6d4286
unhelpful error reporting for invalid Permalinks/Source links
This fixes #123
Project: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/commit/b8b6d428
Tree: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/tree/b8b6d428
Diff: http://git-wip-us.apache.org/repos/asf/incubator-ponymail/diff/b8b6d428
Branch: refs/heads/master
Commit: b8b6d4286e7d84354e4ed336155f1b71faf90fc5
Parents: 5d09ac1
Author: Sebb <se...@apache.org>
Authored: Mon Dec 19 21:03:53 2016 +0000
Committer: Sebb <se...@apache.org>
Committed: Mon Dec 19 21:03:53 2016 +0000
----------------------------------------------------------------------
CHANGELOG.md | 1 +
site/js/dev/ponymail_email_displays.js | 12 +++++-------
site/js/ponymail.js | 12 +++++-------
3 files changed, 11 insertions(+), 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-ponymail/blob/b8b6d428/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 652eec4..56d7705 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -90,6 +90,7 @@
- manage e-mails can create multiple identical alternate addresses (#307)
- elastic.get does not return if a document is not found but some callers overlook this (#137)
- pcall() idiom to protect against elastic.lua exceptions is flawed (#162)
+- unhelpful error reporting for invalid Permalinks/Source links (#123)
## CHANGES in 0.9b:
http://git-wip-us.apache.org/repos/asf/incubator-ponymail/blob/b8b6d428/site/js/dev/ponymail_email_displays.js
----------------------------------------------------------------------
diff --git a/site/js/dev/ponymail_email_displays.js b/site/js/dev/ponymail_email_displays.js
index b128775..e04e605 100644
--- a/site/js/dev/ponymail_email_displays.js
+++ b/site/js/dev/ponymail_email_displays.js
@@ -480,13 +480,11 @@ function displaySingleThread(json) {
// Sometimes emails are hidden for anonymous users, let's make 'em know...
if (!current_thread_json[0]) {
- if (!login || !login.credentials) {
- popup("Email not found!",
- ["Sorry, it seems like we couldn't find this email for you.",
- "It may be private and hidden for non-authenticated users.",
- "In which case you could <a href='/oauth.html'>Log in</a> and see if that helps."],
- 60)
- }
+ popup("Email not found!",
+ ["Sorry, it seems like we couldn't find this email for you.",
+ "It may be private and hidden for non-authenticated users.",
+ "In which case you could <a href='/oauth.html'>Log in</a> and see if that helps."],
+ 60)
}
var mid = current_thread_json[0].mid.replace(/[<>]/g, "")
if (mid.length > 40) {
http://git-wip-us.apache.org/repos/asf/incubator-ponymail/blob/b8b6d428/site/js/ponymail.js
----------------------------------------------------------------------
diff --git a/site/js/ponymail.js b/site/js/ponymail.js
index e4e3338..8b5b2a5 100644
--- a/site/js/ponymail.js
+++ b/site/js/ponymail.js
@@ -1838,13 +1838,11 @@ function displaySingleThread(json) {
// Sometimes emails are hidden for anonymous users, let's make 'em know...
if (!current_thread_json[0]) {
- if (!login || !login.credentials) {
- popup("Email not found!",
- ["Sorry, it seems like we couldn't find this email for you.",
- "It may be private and hidden for non-authenticated users.",
- "In which case you could <a href='/oauth.html'>Log in</a> and see if that helps."],
- 60)
- }
+ popup("Email not found!",
+ ["Sorry, it seems like we couldn't find this email for you.",
+ "It may be private and hidden for non-authenticated users.",
+ "In which case you could <a href='/oauth.html'>Log in</a> and see if that helps."],
+ 60)
}
var mid = current_thread_json[0].mid.replace(/[<>]/g, "")
if (mid.length > 40) {