You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/20 07:00:52 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
AngersZhuuuu opened a new pull request #34954:
URL: https://github.com/apache/spark/pull/34954
### What changes were proposed in this pull request?
We meet a case that when there is a empty relation, HashAggregateExec still triggered to execute and return an empty result. It's not necessart
It's caused by there is an `Expand(EmptyLocalRelation())`, and it's not propagated, this pr support propagate `Expand` with empty LocalRelation
### Why are the changes needed?
Avoid unnecessary execution.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997673438
**[Test build #146387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146387/testReport)** for PR 34954 at commit [`f3bf3fa`](https://github.com/apache/spark/commit/f3bf3fa5872f3bbe774666fd797a4b7ff4074db3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997892344
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146387/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997701868
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50862/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997757416
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50862/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997892344
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146387/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997888750
**[Test build #146387 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146387/testReport)** for PR 34954 at commit [`f3bf3fa`](https://github.com/apache/spark/commit/f3bf3fa5872f3bbe774666fd797a4b7ff4074db3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34954:
URL: https://github.com/apache/spark/pull/34954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997735330
ping @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997758953
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997755943
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50862/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997673438
**[Test build #146387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146387/testReport)** for PR 34954 at commit [`f3bf3fa`](https://github.com/apache/spark/commit/f3bf3fa5872f3bbe774666fd797a4b7ff4074db3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34954:
URL: https://github.com/apache/spark/pull/34954#issuecomment-997757416
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50862/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org