You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/03/14 00:18:15 UTC
[kudu-CR] Add InboundCall::GetTransferSize()
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6374
Change subject: Add InboundCall::GetTransferSize()
......................................................................
Add InboundCall::GetTransferSize()
Returns what you might expect: the size of the transfer, or 0 if it's
been discarded. This has been useful for adding instrumentation to RPC
calls in their service pool.
Change-Id: I9d17963dc3ab271f560309d4aa5b4f9939cba403
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/rpc-test-base.h
3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/6374/1
--
To view, visit http://gerrit.cloudera.org:8080/6374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d17963dc3ab271f560309d4aa5b4f9939cba403
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[kudu-CR] Add InboundCall::GetTransferSize()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add InboundCall::GetTransferSize()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d17963dc3ab271f560309d4aa5b4f9939cba403
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add InboundCall::GetTransferSize()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Add InboundCall::GetTransferSize()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6374/1/src/kudu/rpc/rpc-test-base.h
File src/kudu/rpc/rpc-test-base.h:
Line 188: CHECK_LT(0, incoming->GetTransferSize());
This feels somewhat unidiomatic; maybe convert to CHECK_GT(size, 0)?
--
To view, visit http://gerrit.cloudera.org:8080/6374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d17963dc3ab271f560309d4aa5b4f9939cba403
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Add InboundCall::GetTransferSize()
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Add InboundCall::GetTransferSize()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6374/1/src/kudu/rpc/rpc-test-base.h
File src/kudu/rpc/rpc-test-base.h:
Line 188: CHECK_LT(0, incoming->GetTransferSize());
> This feels somewhat unidiomatic; maybe convert to CHECK_GT(size, 0)?
Done
--
To view, visit http://gerrit.cloudera.org:8080/6374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d17963dc3ab271f560309d4aa5b4f9939cba403
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Add InboundCall::GetTransferSize()
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6374
to look at the new patch set (#2).
Change subject: Add InboundCall::GetTransferSize()
......................................................................
Add InboundCall::GetTransferSize()
Returns what you might expect: the size of the transfer, or 0 if it's
been discarded. This has been useful for adding instrumentation to RPC
calls in their service pool.
Change-Id: I9d17963dc3ab271f560309d4aa5b4f9939cba403
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/rpc-test-base.h
3 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/6374/2
--
To view, visit http://gerrit.cloudera.org:8080/6374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9d17963dc3ab271f560309d4aa5b4f9939cba403
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add InboundCall::GetTransferSize()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: Add InboundCall::GetTransferSize()
......................................................................
Add InboundCall::GetTransferSize()
Returns what you might expect: the size of the transfer, or 0 if it's
been discarded. This has been useful for adding instrumentation to RPC
calls in their service pool.
Change-Id: I9d17963dc3ab271f560309d4aa5b4f9939cba403
Reviewed-on: http://gerrit.cloudera.org:8080/6374
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/rpc-test-base.h
3 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d17963dc3ab271f560309d4aa5b4f9939cba403
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins