[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #369: [FLINK-29964] Support Spark/Hive with OSS

[GitBox <gi...@apache.org>]

LadyForest commented on code in PR #369:
URL: https://github.com/apache/flink-table-store/pull/369#discussion_r1033374714


##########
flink-table-store-hive/flink-table-store-hive-catalog/pom.xml:
##########
@@ -445,6 +445,28 @@ under the License.
                     <groupId>org.pentaho</groupId>
                     <artifactId>pentaho-aggdesigner-algorithm</artifactId>
                 </exclusion>
+                <!-- Exclude the older hadoop-common-->
+                <exclusion>
+                    <groupId>org.apache.hadoop</groupId>
+                    <artifactId>hadoop-common</artifactId>
+                </exclusion>
+            </exclusions>
+        </dependency>
+        <dependency>

Review Comment:
   Because the Hive E2E test failed before, I debugged and found that `Configuration#getPropsWithPrefix` is introduced since hadoop-common 2.8, while
   `mvn dependency:tree -Dincludes=org.apache.hadoop:hadoop-common`
   reveals we depended on hadoop-common 2.7.2
   ```
   [INFO] org.apache.flink:flink-table-store-hive-catalog:jar:0.3-SNAPSHOT
   [INFO] \- org.apache.hive.hcatalog:hive-webhcat-java-client:jar:2.3.9:test
   [INFO]    \- org.apache.hadoop:hadoop-common:jar:2.7.2:compile
   ```
   
   So I changed it in the first place. But later, I realized that it'd be better not to call `Configuration#getPropsWithPrefix` but forgot to revert this back.
   
   I'll revert it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org