You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/04 07:16:20 UTC
[GitHub] [kafka] dongjinleekr opened a new pull request #10258: KAFKA-12408: Document omitted ReplicaManager metrics
dongjinleekr opened a new pull request #10258:
URL: https://github.com/apache/kafka/pull/10258
I found it while configuring a JMX monitoring.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on a change in pull request #10258: KAFKA-12408: Document omitted ReplicaManager metrics
Posted by GitBox <gi...@apache.org>.
tombentley commented on a change in pull request #10258:
URL: https://github.com/apache/kafka/pull/10258#discussion_r611449217
##########
File path: docs/ops.html
##########
@@ -1596,6 +1601,11 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
<td>kafka.server:type=ReplicaManager,name=IsrExpandsPerSec</td>
<td>See above</td>
</tr>
+ <tr>
+ <td>Failed ISR update rate</td>
+ <td>kafka.server:type=ReplicaManager,name=FailedIsrUpdatesPerSec</td>
+ <td>The rate of new ISR update failure.</td>
Review comment:
0
##########
File path: docs/ops.html
##########
@@ -1576,12 +1576,17 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
<tr>
<td>Partition counts</td>
<td>kafka.server:type=ReplicaManager,name=PartitionCount</td>
- <td>mostly even across brokers</td>
+ <td>The number of partitions assigned to the broker.</td>
+ </tr>
+ <tr>
+ <td>Offline Replica counts</td>
+ <td>kafka.server:type=ReplicaManager,name=OfflineReplicaCount</td>
+ <td>The number of offline partitions assigned to the broker.</td>
Review comment:
The normal value of this one should be zero.
##########
File path: docs/ops.html
##########
@@ -1576,12 +1576,17 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
<tr>
<td>Partition counts</td>
<td>kafka.server:type=ReplicaManager,name=PartitionCount</td>
- <td>mostly even across brokers</td>
+ <td>The number of partitions assigned to the broker.</td>
Review comment:
The 3rd column is the normal value, not a description, so "mostly even across brokers" is actually correct.
##########
File path: docs/ops.html
##########
@@ -1576,12 +1576,17 @@ <h4 class="anchor-heading"><a id="remote_jmx" class="anchor-link"></a><a href="#
<tr>
<td>Partition counts</td>
<td>kafka.server:type=ReplicaManager,name=PartitionCount</td>
- <td>mostly even across brokers</td>
+ <td>The number of partitions assigned to the broker.</td>
+ </tr>
+ <tr>
+ <td>Offline Replica counts</td>
+ <td>kafka.server:type=ReplicaManager,name=OfflineReplicaCount</td>
+ <td>The number of offline partitions assigned to the broker.</td>
</tr>
<tr>
<td>Leader replica counts</td>
<td>kafka.server:type=ReplicaManager,name=LeaderCount</td>
- <td>mostly even across brokers</td>
+ <td>The number of leader partitions assigned to the broker.</td>
Review comment:
Again, "mostly even across brokers" is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #10258: KAFKA-12408: Document omitted ReplicaManager metrics
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10258:
URL: https://github.com/apache/kafka/pull/10258#issuecomment-792268829
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #10258: KAFKA-12408: Document omitted ReplicaManager metrics
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10258:
URL: https://github.com/apache/kafka/pull/10258#issuecomment-801563689
@ableegoldman @dajac @tombentley Could you have a look? If fixes errors in JMX documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #10258: KAFKA-12408: Document omitted ReplicaManager metrics
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #10258:
URL: https://github.com/apache/kafka/pull/10258#issuecomment-817746008
Hi @tombentley
Thanks for pointing out my mistakes. Here is the update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley merged pull request #10258: KAFKA-12408: Document omitted ReplicaManager metrics
Posted by GitBox <gi...@apache.org>.
tombentley merged pull request #10258:
URL: https://github.com/apache/kafka/pull/10258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr removed a comment on pull request #10258: KAFKA-12408: Document omitted ReplicaManager metrics
Posted by GitBox <gi...@apache.org>.
dongjinleekr removed a comment on pull request #10258:
URL: https://github.com/apache/kafka/pull/10258#issuecomment-792268829
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org