[PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill opened a new pull request, #4900:
URL: https://github.com/apache/ignite-3/pull/4900

   https://issues.apache.org/jira/browse/IGNITE-23972


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill merged PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886463723


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteLoggerImpl.java:
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import java.lang.System.Logger.Level;
+import java.util.Objects;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteLoggerImpl implements IgniteLogger {
+    /** Logger delegate. */
+    final System.Logger delegate;
+
+    /**
+     * Creates logger facade for a given delegate.
+     *
+     * @param delegate The delegate to create facade for.
+     */
+    IgniteLoggerImpl(System.Logger delegate) {
+        this.delegate = delegate;
+    }
+
+    @Override
+    public void info(String msg, Object... params) {
+        logInternal(Level.INFO, msg, null, params);
+    }
+
+    @Override
+    public void info(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.INFO, msg, th, params);
+    }
+
+    @Override
+    public void info(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.INFO, msgSupplier, th);
+    }
+
+    @Override
+    public void info(String msg, @Nullable Throwable th) {
+        delegate.log(Level.INFO, msg, th);
+    }
+
+    @Override
+    public void debug(String msg, Object... params) {
+        logInternal(Level.DEBUG, msg, null, params);
+    }
+
+    @Override
+    public void debug(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.DEBUG, msg, th, params);
+    }
+
+    @Override
+    public void debug(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.DEBUG, msgSupplier, th);
+    }
+
+    @Override
+    public void debug(String msg, @Nullable Throwable th) {
+        delegate.log(Level.DEBUG, msg, th);
+    }
+
+    @Override
+    public void warn(String msg, Object... params) {
+        logInternal(Level.WARNING, msg, null, params);
+    }
+
+    @Override
+    public void warn(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.WARNING, msg, th, params);
+    }
+
+    @Override
+    public void warn(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.WARNING, msgSupplier, th);
+    }
+
+    @Override
+    public void warn(String msg, @Nullable Throwable th) {
+        delegate.log(Level.WARNING, msg, th);
+    }
+
+    @Override
+    public void error(String msg, Object... params) {
+        logInternal(Level.ERROR, msg, null, params);
+    }
+
+    @Override
+    public void error(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.ERROR, msg, th, params);
+    }
+
+    @Override
+    public void error(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.ERROR, msgSupplier, th);
+    }
+
+    @Override
+    public void error(String msg, @Nullable Throwable th) {
+        delegate.log(Level.ERROR, msg, th);
+    }
+
+    @Override
+    public void trace(String msg, Object... params) {
+        logInternal(Level.TRACE, msg, null, params);
+    }
+
+    @Override
+    public void trace(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.TRACE, msg, th, params);
+    }
+
+    @Override
+    public void trace(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.TRACE, msgSupplier, th);
+    }
+
+    @Override
+    public void trace(String msg, @Nullable Throwable th) {
+        delegate.log(Level.TRACE, msg, th);
+    }
+
+    /**
+     * Logs a message with an optional list of parameters.
+     *
+     * @param level  One of the log message level identifiers.

Review Comment:
   I would fix this, this code is displayed as new anyway



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886458434


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteLoggerImpl.java:
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import java.lang.System.Logger.Level;
+import java.util.Objects;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteLoggerImpl implements IgniteLogger {
+    /** Logger delegate. */
+    final System.Logger delegate;
+
+    /**
+     * Creates logger facade for a given delegate.
+     *
+     * @param delegate The delegate to create facade for.
+     */
+    IgniteLoggerImpl(System.Logger delegate) {
+        this.delegate = delegate;
+    }
+
+    @Override
+    public void info(String msg, Object... params) {
+        logInternal(Level.INFO, msg, null, params);
+    }
+
+    @Override
+    public void info(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.INFO, msg, th, params);
+    }
+
+    @Override
+    public void info(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.INFO, msgSupplier, th);
+    }
+
+    @Override
+    public void info(String msg, @Nullable Throwable th) {
+        delegate.log(Level.INFO, msg, th);
+    }
+
+    @Override
+    public void debug(String msg, Object... params) {
+        logInternal(Level.DEBUG, msg, null, params);
+    }
+
+    @Override
+    public void debug(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.DEBUG, msg, th, params);
+    }
+
+    @Override
+    public void debug(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.DEBUG, msgSupplier, th);
+    }
+
+    @Override
+    public void debug(String msg, @Nullable Throwable th) {
+        delegate.log(Level.DEBUG, msg, th);
+    }
+
+    @Override
+    public void warn(String msg, Object... params) {
+        logInternal(Level.WARNING, msg, null, params);
+    }
+
+    @Override
+    public void warn(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.WARNING, msg, th, params);
+    }
+
+    @Override
+    public void warn(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.WARNING, msgSupplier, th);
+    }
+
+    @Override
+    public void warn(String msg, @Nullable Throwable th) {
+        delegate.log(Level.WARNING, msg, th);
+    }
+
+    @Override
+    public void error(String msg, Object... params) {
+        logInternal(Level.ERROR, msg, null, params);
+    }
+
+    @Override
+    public void error(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.ERROR, msg, th, params);
+    }
+
+    @Override
+    public void error(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.ERROR, msgSupplier, th);
+    }
+
+    @Override
+    public void error(String msg, @Nullable Throwable th) {
+        delegate.log(Level.ERROR, msg, th);
+    }
+
+    @Override
+    public void trace(String msg, Object... params) {
+        logInternal(Level.TRACE, msg, null, params);
+    }
+
+    @Override
+    public void trace(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.TRACE, msg, th, params);
+    }
+
+    @Override
+    public void trace(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.TRACE, msgSupplier, th);
+    }
+
+    @Override
+    public void trace(String msg, @Nullable Throwable th) {
+        delegate.log(Level.TRACE, msg, th);
+    }
+
+    /**
+     * Logs a message with an optional list of parameters.
+     *
+     * @param level  One of the log message level identifiers.

Review Comment:
   I used refactoring tools to create an interface from a class and IDEA itself made the alignment into interfaces, but I did not touch this method, so the alignment did not change.
   Should I fix it or leave it as is?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886459478


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = new ConcurrentHashMap<>(capacity(128), 0.75f);

Review Comment:
   Artifact during porting, I think that arguments are not needed here at all, I will delete them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886470162


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = new ConcurrentHashMap<>(capacity(128), 0.75f);
+
+    IgniteThrottledLoggerImpl(Logger delegate, ScheduledExecutorService scheduledExecutor, ExecutorService executor) {

Review Comment:
   I think it is more correct to use `scheduledExecutor` only for initiating a background long task.
   For example, this approach allows us to use `commonScheduler` without any problems.
   Accordingly, the second executor is needed to clear messages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886655320


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = new ConcurrentHashMap<>(capacity(128), 0.75f);

Review Comment:
   Replaced with a caffeine map.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886495424


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = new ConcurrentHashMap<>(capacity(128), 0.75f);
+
+    IgniteThrottledLoggerImpl(Logger delegate, ScheduledExecutorService scheduledExecutor, ExecutorService executor) {

Review Comment:
   In general, I agree. But why do you think that cleaning a map is a "long" task?



##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = new ConcurrentHashMap<>(capacity(128), 0.75f);
+
+    IgniteThrottledLoggerImpl(Logger delegate, ScheduledExecutorService scheduledExecutor, ExecutorService executor) {

Review Comment:
   In general, I agree. But why do you think that cleaning a map is a "long" task? It doesn't perform any IO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1884074073


##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java:
##########
@@ -0,0 +1,532 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tostring;
+
+import static org.apache.ignite.internal.util.ArrayUtils.OBJECT_EMPTY_ARRAY;
+import static org.apache.ignite.internal.util.ArrayUtils.nullOrEmpty;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.logger.IgniteLogger;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Log throttle.
+ *
+ * <p>Errors are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes.</p>
+ */
+public class IgniteLogThrottle {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    private static final long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /** Log messages. */
+    private static final ConcurrentMap<LogThrottleKey, Long> MESSAGES_MAP = new ConcurrentHashMap<>(128, 0.75f);

Review Comment:
   please use the `IgniteUtils#capacity` method



##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java:
##########
@@ -0,0 +1,532 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tostring;
+
+import static org.apache.ignite.internal.util.ArrayUtils.OBJECT_EMPTY_ARRAY;
+import static org.apache.ignite.internal.util.ArrayUtils.nullOrEmpty;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.logger.IgniteLogger;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Log throttle.
+ *
+ * <p>Errors are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes.</p>
+ */
+public class IgniteLogThrottle {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    private static final long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /** Log messages. */
+    private static final ConcurrentMap<LogThrottleKey, Long> MESSAGES_MAP = new ConcurrentHashMap<>(128, 0.75f);
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String msg) {
+        error(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e) {
+        error(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, Object... params) {
+        error(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg) {
+        error(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        error(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        error(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String msg) {
+        warn(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e) {
+        warn(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, Object... params) {
+        warn(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg) {
+        warn(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        warn(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        warn(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String msg) {
+        info(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e) {
+        info(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, Object... params) {
+        info(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg) {
+        info(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        info(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        info(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String msg) {
+        debug(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e) {
+        debug(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, Object... params) {
+        debug(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.DEBUG, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg) {
+        debug(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        debug(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        debug(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.DEBUG, params);
+    }
+
+    /** Clears cached messages. */
+    public static void clean() {

Review Comment:
   Also, should we call it `clear` instead of `clean`?



##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java:
##########
@@ -0,0 +1,532 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tostring;
+
+import static org.apache.ignite.internal.util.ArrayUtils.OBJECT_EMPTY_ARRAY;
+import static org.apache.ignite.internal.util.ArrayUtils.nullOrEmpty;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.logger.IgniteLogger;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Log throttle.
+ *
+ * <p>Errors are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes.</p>
+ */
+public class IgniteLogThrottle {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    private static final long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /** Log messages. */
+    private static final ConcurrentMap<LogThrottleKey, Long> MESSAGES_MAP = new ConcurrentHashMap<>(128, 0.75f);
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String msg) {
+        error(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e) {
+        error(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, Object... params) {
+        error(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg) {
+        error(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        error(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        error(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String msg) {
+        warn(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e) {
+        warn(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, Object... params) {
+        warn(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg) {
+        warn(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        warn(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        warn(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String msg) {
+        info(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e) {
+        info(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, Object... params) {
+        info(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg) {
+        info(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        info(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        info(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String msg) {
+        debug(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e) {
+        debug(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, Object... params) {
+        debug(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.DEBUG, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg) {
+        debug(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        debug(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        debug(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.DEBUG, params);
+    }
+
+    /** Clears cached messages. */
+    public static void clean() {
+        MESSAGES_MAP.clear();
+    }
+
+    /**
+     * Logs message if needed using desired level.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param longMsg Long message/message pattern.
+     * @param throttleKey Throttle key (optional).
+     * @param level Level where messages should appear.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    private static void log(
+            IgniteLogger log,
+            @Nullable Throwable e,
+            @Nullable String throttleKey,
+            String longMsg,
+            LogLevel level,
+            Object... params
+    ) {
+        String errorMessage = nullOrEmpty(params) ? longMsg : IgniteStringFormatter.format(longMsg, params);
+
+        var msgKey = new LogThrottleKey(e, throttleKey == null ? errorMessage : throttleKey);
+
+        while (true) {
+            Long loggedTs = MESSAGES_MAP.get(msgKey);
+
+            long curTs = FastTimestamps.coarseCurrentTimeMillis();
+
+            if (loggedTs == null || loggedTs < curTs - THROTTLE_TIMEOUT_MILLIS) {

Review Comment:
   Minor nitpick: I think `curTs - loggedTs > THROTTLE_TIMEOUT_MILLIS` is easier to understand



##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java:
##########
@@ -0,0 +1,532 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tostring;
+
+import static org.apache.ignite.internal.util.ArrayUtils.OBJECT_EMPTY_ARRAY;
+import static org.apache.ignite.internal.util.ArrayUtils.nullOrEmpty;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.logger.IgniteLogger;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Log throttle.
+ *
+ * <p>Errors are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes.</p>
+ */
+public class IgniteLogThrottle {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    private static final long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /** Log messages. */
+    private static final ConcurrentMap<LogThrottleKey, Long> MESSAGES_MAP = new ConcurrentHashMap<>(128, 0.75f);
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String msg) {

Review Comment:
   Instead of using static methods, could we use inheritance and have something like `IgniteThrottledLogger`?



##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java:
##########
@@ -0,0 +1,532 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tostring;
+
+import static org.apache.ignite.internal.util.ArrayUtils.OBJECT_EMPTY_ARRAY;
+import static org.apache.ignite.internal.util.ArrayUtils.nullOrEmpty;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.logger.IgniteLogger;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Log throttle.
+ *
+ * <p>Errors are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes.</p>
+ */
+public class IgniteLogThrottle {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    private static final long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /** Log messages. */
+    private static final ConcurrentMap<LogThrottleKey, Long> MESSAGES_MAP = new ConcurrentHashMap<>(128, 0.75f);
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String msg) {
+        error(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e) {
+        error(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, Object... params) {
+        error(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg) {
+        error(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        error(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        error(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String msg) {
+        warn(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e) {
+        warn(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, Object... params) {
+        warn(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg) {
+        warn(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        warn(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        warn(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String msg) {
+        info(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e) {
+        info(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, Object... params) {
+        info(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg) {
+        info(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        info(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        info(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String msg) {
+        debug(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e) {
+        debug(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, Object... params) {
+        debug(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.DEBUG, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg) {
+        debug(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        debug(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        debug(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.DEBUG, params);
+    }
+
+    /** Clears cached messages. */
+    public static void clean() {

Review Comment:
   Do we ever call this method? Because its usage in ReplicaManager looks like a memory leak to me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886657671


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLogger.java:
##########
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import java.lang.System.Logger.Level;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * {@link IgniteLogger} throttle.
+ *
+ * <p>Messages are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes if present.</p>
+ */
+public interface IgniteThrottledLogger extends IgniteLogger {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /**
+     * Logs a message on {@link Level#INFO} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void info(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#INFO} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void info(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#INFO} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void info(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#INFO} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void info(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void debug(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void debug(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#DEBUG} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void debug(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message;
+     */
+    void debug(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void warn(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void warn(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#WARNING} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void warn(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void warn(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void error(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void error(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#ERROR} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void error(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void error(String throttleKey, String msg, @Nullable Throwable th);

Review Comment:
   For example in `org.apache.ignite.internal.processors.query.h2.H2QueryInfo#printLogMessage`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886496338


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLogger.java:
##########
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import java.lang.System.Logger.Level;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * {@link IgniteLogger} throttle.
+ *
+ * <p>Messages are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes if present.</p>
+ */
+public interface IgniteThrottledLogger extends IgniteLogger {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /**
+     * Logs a message on {@link Level#INFO} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void info(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#INFO} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void info(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#INFO} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void info(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#INFO} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void info(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void debug(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void debug(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#DEBUG} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void debug(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message;
+     */
+    void debug(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void warn(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void warn(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#WARNING} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void warn(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void warn(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void error(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void error(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#ERROR} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void error(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void error(String throttleKey, String msg, @Nullable Throwable th);

Review Comment:
   Are they used in Ignite 2?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886654974


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = new ConcurrentHashMap<>(capacity(128), 0.75f);
+
+    IgniteThrottledLoggerImpl(Logger delegate, ScheduledExecutorService scheduledExecutor, ExecutorService executor) {

Review Comment:
   Replaced with a caffeine map, no more executors needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886394055


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteLoggerImpl.java:
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import java.lang.System.Logger.Level;
+import java.util.Objects;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteLoggerImpl implements IgniteLogger {
+    /** Logger delegate. */
+    final System.Logger delegate;
+
+    /**
+     * Creates logger facade for a given delegate.
+     *
+     * @param delegate The delegate to create facade for.
+     */
+    IgniteLoggerImpl(System.Logger delegate) {
+        this.delegate = delegate;
+    }
+
+    @Override
+    public void info(String msg, Object... params) {
+        logInternal(Level.INFO, msg, null, params);
+    }
+
+    @Override
+    public void info(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.INFO, msg, th, params);
+    }
+
+    @Override
+    public void info(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.INFO, msgSupplier, th);
+    }
+
+    @Override
+    public void info(String msg, @Nullable Throwable th) {
+        delegate.log(Level.INFO, msg, th);
+    }
+
+    @Override
+    public void debug(String msg, Object... params) {
+        logInternal(Level.DEBUG, msg, null, params);
+    }
+
+    @Override
+    public void debug(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.DEBUG, msg, th, params);
+    }
+
+    @Override
+    public void debug(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.DEBUG, msgSupplier, th);
+    }
+
+    @Override
+    public void debug(String msg, @Nullable Throwable th) {
+        delegate.log(Level.DEBUG, msg, th);
+    }
+
+    @Override
+    public void warn(String msg, Object... params) {
+        logInternal(Level.WARNING, msg, null, params);
+    }
+
+    @Override
+    public void warn(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.WARNING, msg, th, params);
+    }
+
+    @Override
+    public void warn(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.WARNING, msgSupplier, th);
+    }
+
+    @Override
+    public void warn(String msg, @Nullable Throwable th) {
+        delegate.log(Level.WARNING, msg, th);
+    }
+
+    @Override
+    public void error(String msg, Object... params) {
+        logInternal(Level.ERROR, msg, null, params);
+    }
+
+    @Override
+    public void error(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.ERROR, msg, th, params);
+    }
+
+    @Override
+    public void error(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.ERROR, msgSupplier, th);
+    }
+
+    @Override
+    public void error(String msg, @Nullable Throwable th) {
+        delegate.log(Level.ERROR, msg, th);
+    }
+
+    @Override
+    public void trace(String msg, Object... params) {
+        logInternal(Level.TRACE, msg, null, params);
+    }
+
+    @Override
+    public void trace(String msg, @Nullable Throwable th, Object... params) {
+        logInternal(Level.TRACE, msg, th, params);
+    }
+
+    @Override
+    public void trace(Supplier<String> msgSupplier, @Nullable Throwable th) {
+        logInternalExceptional(Level.TRACE, msgSupplier, th);
+    }
+
+    @Override
+    public void trace(String msg, @Nullable Throwable th) {
+        delegate.log(Level.TRACE, msg, th);
+    }
+
+    /**
+     * Logs a message with an optional list of parameters.
+     *
+     * @param level  One of the log message level identifiers.

Review Comment:
   Why did you remove parameter alignment from `IgniteLogger`, but kept it here?)



##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteLoggerImpl.java:
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import java.lang.System.Logger.Level;
+import java.util.Objects;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteLoggerImpl implements IgniteLogger {

Review Comment:
   I would suggest to call this class `IgniteSystemLogger`



##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLogger.java:
##########
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import java.lang.System.Logger.Level;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * {@link IgniteLogger} throttle.
+ *
+ * <p>Messages are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes if present.</p>
+ */
+public interface IgniteThrottledLogger extends IgniteLogger {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /**
+     * Logs a message on {@link Level#INFO} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void info(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#INFO} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void info(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#INFO} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void info(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#INFO} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void info(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void debug(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void debug(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#DEBUG} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void debug(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message;
+     */
+    void debug(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void warn(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void warn(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#WARNING} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void warn(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void warn(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void error(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void error(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#ERROR} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void error(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void error(String throttleKey, String msg, @Nullable Throwable th);

Review Comment:
   Do we really need all these methods now? I mean the ones with the `throttleKey`, for example?



##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = new ConcurrentHashMap<>(capacity(128), 0.75f);

Review Comment:
   I can see that we have `caffeine` in our list of dependencies, maybe we can use it here? It has a configuration that removes entries if they haven't been accessed in a specified duration.



##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = new ConcurrentHashMap<>(capacity(128), 0.75f);

Review Comment:
   why do you explicitly specify the load factor?



##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = new ConcurrentHashMap<>(capacity(128), 0.75f);
+
+    IgniteThrottledLoggerImpl(Logger delegate, ScheduledExecutorService scheduledExecutor, ExecutorService executor) {

Review Comment:
   Do we really need two executors here? What's wrong with clearing messages inside `scheduledExecutor`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886454268


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteLoggerImpl.java:
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import java.lang.System.Logger.Level;
+import java.util.Objects;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteLoggerImpl implements IgniteLogger {

Review Comment:
   I would leave it as is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1885050151


##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java:
##########
@@ -0,0 +1,532 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tostring;
+
+import static org.apache.ignite.internal.util.ArrayUtils.OBJECT_EMPTY_ARRAY;
+import static org.apache.ignite.internal.util.ArrayUtils.nullOrEmpty;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.logger.IgniteLogger;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Log throttle.
+ *
+ * <p>Errors are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes.</p>
+ */
+public class IgniteLogThrottle {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    private static final long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /** Log messages. */
+    private static final ConcurrentMap<LogThrottleKey, Long> MESSAGES_MAP = new ConcurrentHashMap<>(128, 0.75f);
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String msg) {
+        error(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e) {
+        error(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, Object... params) {
+        error(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg) {
+        error(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        error(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        error(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String msg) {
+        warn(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e) {
+        warn(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, Object... params) {
+        warn(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg) {
+        warn(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        warn(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        warn(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String msg) {
+        info(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e) {
+        info(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, Object... params) {
+        info(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg) {
+        info(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        info(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        info(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String msg) {
+        debug(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e) {
+        debug(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, Object... params) {
+        debug(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.DEBUG, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg) {
+        debug(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        debug(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        debug(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.DEBUG, params);
+    }
+
+    /** Clears cached messages. */
+    public static void clean() {

Review Comment:
   I removed the method.
   I didn't know how to do the message clearing better, but for now I did the first option, I'm interested in your opinion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1884988614


##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java:
##########
@@ -0,0 +1,532 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tostring;
+
+import static org.apache.ignite.internal.util.ArrayUtils.OBJECT_EMPTY_ARRAY;
+import static org.apache.ignite.internal.util.ArrayUtils.nullOrEmpty;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.logger.IgniteLogger;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Log throttle.
+ *
+ * <p>Errors are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes.</p>
+ */
+public class IgniteLogThrottle {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    private static final long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /** Log messages. */
+    private static final ConcurrentMap<LogThrottleKey, Long> MESSAGES_MAP = new ConcurrentHashMap<>(128, 0.75f);
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String msg) {
+        error(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e) {
+        error(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, Object... params) {
+        error(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg) {
+        error(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        error(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        error(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String msg) {
+        warn(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e) {
+        warn(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, Object... params) {
+        warn(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg) {
+        warn(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        warn(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        warn(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String msg) {
+        info(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e) {
+        info(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, Object... params) {
+        info(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg) {
+        info(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        info(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        info(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String msg) {
+        debug(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e) {
+        debug(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, Object... params) {
+        debug(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.DEBUG, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg) {
+        debug(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        debug(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        debug(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.DEBUG, params);
+    }
+
+    /** Clears cached messages. */
+    public static void clean() {

Review Comment:
   There is no longer a method.



##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java:
##########
@@ -0,0 +1,532 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tostring;
+
+import static org.apache.ignite.internal.util.ArrayUtils.OBJECT_EMPTY_ARRAY;
+import static org.apache.ignite.internal.util.ArrayUtils.nullOrEmpty;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.logger.IgniteLogger;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Log throttle.
+ *
+ * <p>Errors are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes.</p>
+ */
+public class IgniteLogThrottle {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    private static final long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /** Log messages. */
+    private static final ConcurrentMap<LogThrottleKey, Long> MESSAGES_MAP = new ConcurrentHashMap<>(128, 0.75f);
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String msg) {
+        error(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e) {
+        error(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, Object... params) {
+        error(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg) {
+        error(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        error(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        error(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String msg) {
+        warn(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e) {
+        warn(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, Object... params) {
+        warn(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg) {
+        warn(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        warn(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        warn(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String msg) {
+        info(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e) {
+        info(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, Object... params) {
+        info(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg) {
+        info(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        info(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        info(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String msg) {
+        debug(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e) {
+        debug(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, Object... params) {
+        debug(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.DEBUG, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg) {
+        debug(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        debug(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        debug(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.DEBUG, params);
+    }
+
+    /** Clears cached messages. */
+    public static void clean() {

Review Comment:
   Deleted it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1884988433


##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java:
##########
@@ -0,0 +1,532 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tostring;
+
+import static org.apache.ignite.internal.util.ArrayUtils.OBJECT_EMPTY_ARRAY;
+import static org.apache.ignite.internal.util.ArrayUtils.nullOrEmpty;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.logger.IgniteLogger;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Log throttle.
+ *
+ * <p>Errors are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes.</p>
+ */
+public class IgniteLogThrottle {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    private static final long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /** Log messages. */
+    private static final ConcurrentMap<LogThrottleKey, Long> MESSAGES_MAP = new ConcurrentHashMap<>(128, 0.75f);
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String msg) {
+        error(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e) {
+        error(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, Object... params) {
+        error(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg) {
+        error(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        error(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        error(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void error(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.ERROR, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String msg) {
+        warn(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e) {
+        warn(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, Object... params) {
+        warn(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg) {
+        warn(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        warn(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        warn(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs warn if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void warn(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.WARN, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String msg) {
+        info(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e) {
+        info(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, Object... params) {
+        info(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg) {
+        info(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        info(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        info(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs info if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void info(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.INFO, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String msg) {
+        debug(log, msg, (Throwable) null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     * @param e Error (optional).
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e) {
+        debug(log, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, Object... params) {
+        debug(log, msg, (Throwable) null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param e Error (optional).
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, null, msg, LogLevel.DEBUG, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg) {
+        debug(log, throttleKey, msg, null, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param e Error (optional).
+     * @param msg Message.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e) {
+        debug(log, throttleKey, msg, e, OBJECT_EMPTY_ARRAY);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, Object... params) {
+        debug(log, throttleKey, msg, null, params);
+    }
+
+    /**
+     * Logs debug if needed.
+     *
+     * @param log Logger.
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg Message pattern.
+     * @param e Error (optional).
+     * @param params List of arguments to be substituted in place of formatting anchors.
+     */
+    public static void debug(IgniteLogger log, String throttleKey, String msg, @Nullable Throwable e, Object... params) {
+        log(log, e, throttleKey, msg, LogLevel.DEBUG, params);
+    }
+
+    /** Clears cached messages. */
+    public static void clean() {

Review Comment:
   Deleted it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886654249


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = new ConcurrentHashMap<>(capacity(128), 0.75f);

Review Comment:
   Replaced with a caffeine map.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886472068


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLogger.java:
##########
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import java.lang.System.Logger.Level;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * {@link IgniteLogger} throttle.
+ *
+ * <p>Messages are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes if present.</p>
+ */
+public interface IgniteThrottledLogger extends IgniteLogger {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /**
+     * Logs a message on {@link Level#INFO} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void info(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#INFO} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void info(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#INFO} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void info(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#INFO} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void info(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void debug(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void debug(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#DEBUG} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void debug(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#DEBUG} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message;
+     */
+    void debug(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void warn(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void warn(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#WARNING} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void warn(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#WARNING} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void warn(String throttleKey, String msg, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level composed from args with given format.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void error(String throttleKey, String msg, Object... params);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level composed from args with given format and with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be formatted and passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     * @param params The list of arguments to be substituted in place of formatting anchors.
+     */
+    void error(String throttleKey, String msg, @Nullable Throwable th, Object... params);
+
+    /**
+     * Logs a message which produces in {@code msgSupplier}, on {@link Level#ERROR} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msgSupplier A supplier function that produces a message.
+     * @param th The {@code Throwable} associated with log message; can be {@code null}.
+     */
+    void error(String throttleKey, Supplier<String> msgSupplier, @Nullable Throwable th);
+
+    /**
+     * Logs a message on {@link Level#ERROR} level with associated throwable {@code th}.
+     *
+     * @param throttleKey Messages with the same key will be throttled.
+     * @param msg The message pattern which will be passed to the {@link System.Logger}.
+     * @param th The {@code Throwable} associated with the log message.
+     */
+    void error(String throttleKey, String msg, @Nullable Throwable th);

Review Comment:
   I suggest leaving them, maybe they will be needed later, they are in Ignite 2, maybe they will be useful here too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["sashapolo (via GitHub)" <gi...@apache.org>]

sashapolo commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886691006


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,345 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import com.github.benmanes.caffeine.cache.Caffeine;
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = Caffeine.newBuilder()
+            .initialCapacity(capacity(128))
+            .maximumSize(128)

Review Comment:
   Why maximum size and not eviction by last access time?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1886716842


##########
modules/core/src/main/java/org/apache/ignite/internal/logger/IgniteThrottledLoggerImpl.java:
##########
@@ -0,0 +1,345 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.logger;
+
+import static org.apache.ignite.internal.util.IgniteUtils.capacity;
+
+import com.github.benmanes.caffeine.cache.Caffeine;
+import java.lang.System.Logger;
+import java.lang.System.Logger.Level;
+import java.util.Map;
+import java.util.Objects;
+import java.util.function.Supplier;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+class IgniteThrottledLoggerImpl implements IgniteThrottledLogger {
+    /** Logger delegate. */
+    private final System.Logger delegate;
+
+    /** Log messages. */
+    private final Map<LogThrottleKey, Long> messagesMap = Caffeine.newBuilder()
+            .initialCapacity(capacity(128))
+            .maximumSize(128)

Review Comment:
   In general, why not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-23972 Add LogThrottle for ReplicaManager to reduce log stack traces [ignite-3]

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #4900:
URL: https://github.com/apache/ignite-3/pull/4900#discussion_r1884868416


##########
modules/core/src/main/java/org/apache/ignite/internal/tostring/IgniteLogThrottle.java:
##########
@@ -0,0 +1,532 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tostring;
+
+import static org.apache.ignite.internal.util.ArrayUtils.OBJECT_EMPTY_ARRAY;
+import static org.apache.ignite.internal.util.ArrayUtils.nullOrEmpty;
+
+import java.util.Objects;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.lang.IgniteStringFormatter;
+import org.apache.ignite.internal.logger.IgniteLogger;
+import org.apache.ignite.internal.util.FastTimestamps;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Log throttle.
+ *
+ * <p>Errors are logged only if they were not logged for the last {@link #THROTTLE_TIMEOUT_MILLIS} milliseconds. Note that not only error
+ * messages are checked for duplicates, but also exception classes.</p>
+ */
+public class IgniteLogThrottle {
+    /** Throttle timeout in milliseconds (value is 5 min). */
+    private static final long THROTTLE_TIMEOUT_MILLIS = TimeUnit.MINUTES.toMillis(5);
+
+    /** Log messages. */
+    private static final ConcurrentMap<LogThrottleKey, Long> MESSAGES_MAP = new ConcurrentHashMap<>(128, 0.75f);
+
+    /**
+     * Logs error if needed.
+     *
+     * @param log Logger.
+     * @param msg Message.
+     */
+    public static void error(IgniteLogger log, String msg) {

Review Comment:
   Yes, I think it will look more natural.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org