You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "GoSimplicity (via GitHub)" <gi...@apache.org> on 2025/08/29 01:07:27 UTC
[PR] fix(jira): fix type for Jira issue descriptions [incubator-devlake]
GoSimplicity opened a new pull request, #8559:
URL: https://github.com/apache/incubator-devlake/pull/8559
This fix #8558 ensures that the Jira plugin no longer throws JSON deserialization errors when encountering rich-text descriptions, allowing the pipeline to continue running smoothly. Existing string-only descriptions remain fully supported, guaranteeing backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(jira): fix type for Jira issue descriptions [incubator-devlake]
Posted by "davinogueiradev (via GitHub)" <gi...@apache.org>.
davinogueiradev commented on PR #8559:
URL: https://github.com/apache/incubator-devlake/pull/8559#issuecomment-3235516326
I'm testing locally, and not work for all scenarios, reading the [documentation](https://developer.atlassian.com/cloud/jira/platform/rest/v3/intro/#version) others field can be text rich.
```
Issue.Description
Comment.Body
Worklog.Comment
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(jira): fix type for Jira issue descriptions [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on code in PR #8559:
URL: https://github.com/apache/incubator-devlake/pull/8559#discussion_r2312817404
##########
backend/plugins/jira/tasks/apiv2models/issue.go:
##########
@@ -19,13 +19,141 @@ package apiv2models
import (
"encoding/json"
+ "strings"
"time"
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/models/common"
"github.com/apache/incubator-devlake/plugins/jira/models"
)
+// FlexibleDescription supports both plain text and ADF (Atlassian Document Format) for Jira description field
Review Comment:
Could you add a link to the Atlassian Document Format (e.g., an example) for reference, so others can easily update the logic in the future? Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(jira): fix type for Jira issue descriptions [incubator-devlake]
Posted by "GoSimplicity (via GitHub)" <gi...@apache.org>.
GoSimplicity closed pull request #8559: fix(jira): fix type for Jira issue descriptions
URL: https://github.com/apache/incubator-devlake/pull/8559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(jira): fix type for Jira issue descriptions [incubator-devlake]
Posted by "GoSimplicity (via GitHub)" <gi...@apache.org>.
GoSimplicity commented on code in PR #8559:
URL: https://github.com/apache/incubator-devlake/pull/8559#discussion_r2312838625
##########
backend/plugins/jira/tasks/apiv2models/issue.go:
##########
@@ -19,13 +19,141 @@ package apiv2models
import (
"encoding/json"
+ "strings"
"time"
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/models/common"
"github.com/apache/incubator-devlake/plugins/jira/models"
)
+// FlexibleDescription supports both plain text and ADF (Atlassian Document Format) for Jira description field
Review Comment:
Of course, I will add it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(jira): fix type for Jira issue descriptions [incubator-devlake]
Posted by "GoSimplicity (via GitHub)" <gi...@apache.org>.
GoSimplicity commented on PR #8559:
URL: https://github.com/apache/incubator-devlake/pull/8559#issuecomment-3235628175
> I'm testing locally, and not work for all scenarios, reading the [documentation](https://developer.atlassian.com/cloud/jira/platform/rest/v3/intro/#version) others field can be text rich.
>
> ```
> Issue.Description
> Comment.Body
> Worklog.Comment
> ```
Thanks for the review! This fix covers all rich text fields (Issue.Description, Comment.Body, Worklog.Comment) that can cause the ADF unmarshaling error, including Epic descriptions since they use the Issue struct. The FlexibleDescription type handles both string and ADF formats with full backward compatibility. If you encounter specific scenarios that don't work, please share the error details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(jira): fix type for Jira issue descriptions [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #8559:
URL: https://github.com/apache/incubator-devlake/pull/8559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org