You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/05/27 12:45:56 UTC

[GitHub] [incubator-tubemq] cku328 commented on pull request #99: [TUBEMQ-159] Fix some typos

cku328 commented on pull request #99:
URL: https://github.com/apache/incubator-tubemq/pull/99#issuecomment-634635638


   Thanks @gosonzhang for the review and comments.
   
   I also agree that modifying the external API parameter field is risky, and I re-checked my commit and how it relates to TubeMQ code.
   
   I compared the differences between Chinese and English versions of the HTTP API Definition Guide (`docs/http_access_API_definition.md` and `docs/http_access_API_definition_cn.xls`).
   
   From the Chinese version, I found that the parameter field should be "**allowedBClientRate**", and I verified from some code that this name is correct, like [this](https://github.com/apache/incubator-tubemq/blob/02220e747f4251fa4ddf0eef305bfad31648428e/tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebAdminGroupCtrlHandler.java#L1237:L1238).
   ![image](https://user-images.githubusercontent.com/14295594/83019794-1f3fd800-a05a-11ea-8761-2e842f65cc9c.png)
   
   And the parameter field "**modfiyUser**", I also confirmed that it's just a typo in the document.
   
   I updated my patch based on the above description.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org