You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/04/03 09:28:26 UTC

[GitHub] [incubator-pekko-projection] mdedetrich opened a new pull request, #26: Require single approving review

mdedetrich opened a new pull request, #26:
URL: https://github.com/apache/incubator-pekko-projection/pull/26

   As discussed in mailing list, this PR mandates a single approving PR review before a PR can be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-projection] He-Pin commented on a diff in pull request #26: Require single approving review

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #26:
URL: https://github.com/apache/incubator-pekko-projection/pull/26#discussion_r1155728823


##########
.asf.yaml:
##########
@@ -19,6 +19,11 @@ github:
     merge:   false
     rebase:  true
 
+  required_pull_request_reviews:
+    dismiss_stale_reviews: false
+    require_code_owner_reviews: false
+    required_approving_review_count: 1

Review Comment:
   Cool!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-projection] mdedetrich merged pull request #26: Require single approving review

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #26:
URL: https://github.com/apache/incubator-pekko-projection/pull/26


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org