You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/24 09:24:31 UTC
[GitHub] [doris] englefly opened a new pull request, #13600: [fix](planner) inlineView alias error
englefly opened a new pull request, #13600:
URL: https://github.com/apache/doris/pull/13600
# Proposed changes
set alias for `inlineViewAnalyzaer`, and check alias name when `resolveColumnRef()`
Issue Number: 13431
https://github.com/apache/doris/issues/13431
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13600: [fix](planner) inlineView alias error
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13600:
URL: https://github.com/apache/doris/pull/13600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #13600: [fix](planner) inlineView alias error
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #13600:
URL: https://github.com/apache/doris/pull/13600#discussion_r1004058783
##########
regression-test/suites/correctness/test_pushdown_pred_to_view.groovy:
##########
@@ -54,7 +54,7 @@ The same resolve error occurs when re-analyze v2.
"""
qt_sql """
- select * from ${viewName} as v1 join ${viewName} as v2 on v1.id=v2.id and v1.id>0;
+ select * from ${viewName} as v1 join ${viewName} as v2 where v1.id=v2.id and v1.id>0;
Review Comment:
it is better to add another test case for `join ... on` after we fixed the second bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13600: [fix](planner) inlineView alias error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13600:
URL: https://github.com/apache/doris/pull/13600#issuecomment-1290126605
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13600: [fix](planner) inlineView alias error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13600:
URL: https://github.com/apache/doris/pull/13600#issuecomment-1290126561
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #13600: [fix](planner) inlineView alias error
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #13600:
URL: https://github.com/apache/doris/pull/13600#discussion_r1003095676
##########
regression-test/suites/correctness/test_pushdown_pred_to_view.groovy:
##########
@@ -54,7 +54,7 @@ The same resolve error occurs when re-analyze v2.
"""
qt_sql """
- select * from ${viewName} as v1 join ${viewName} as v2 on v1.id=v2.id and v1.id>0;
+ select * from ${viewName} as v1 join ${viewName} as v2 where v1.id=v2.id and v1.id>0;
Review Comment:
After fix this bug, we found that there is another bug hidden by this bug.
If we use `on` instead of `where`, the planner push `v1.id=v2.id` down to scan node.
That is why we modified the regression test temporarily.
We will fix it latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on pull request #13600: [fix](planner) inlineView alias error
Posted by GitBox <gi...@apache.org>.
englefly commented on PR #13600:
URL: https://github.com/apache/doris/pull/13600#issuecomment-1288725531
After fix this bug, we found that there is another bug hidden by this bug.
the other bug is that planner push a join conjuncts down to scan node.
That is why we modified the regression test temporarily.
We will fix it latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #13600: [fix](planner) inlineView alias error
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #13600:
URL: https://github.com/apache/doris/pull/13600#discussion_r1003249044
##########
regression-test/suites/correctness/test_pushdown_pred_to_view.groovy:
##########
@@ -54,7 +54,7 @@ The same resolve error occurs when re-analyze v2.
"""
qt_sql """
- select * from ${viewName} as v1 join ${viewName} as v2 on v1.id=v2.id and v1.id>0;
+ select * from ${viewName} as v1 join ${viewName} as v2 where v1.id=v2.id and v1.id>0;
Review Comment:
add a TODO to this regression test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org