You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ru...@apache.org on 2007/12/19 14:40:06 UTC
svn commit: r605536 -
/incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
Author: rupertlssmith
Date: Wed Dec 19 05:40:05 2007
New Revision: 605536
URL: http://svn.apache.org/viewvc?rev=605536&view=rev
Log:
Messages were being sent mandatory by default, set to false.
Modified:
incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
Modified: incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
URL: http://svn.apache.org/viewvc/incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs?rev=605536&r1=605535&r2=605536&view=diff
==============================================================================
--- incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs (original)
+++ incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs Wed Dec 19 05:40:05 2007
@@ -31,7 +31,7 @@
/// Default value for mandatory flag is true, i.e. server will not silently drop messages where no queue is
/// connected to the exchange for the message
/// </summary>
- const bool DEFAULT_MANDATORY = true;
+ const bool DEFAULT_MANDATORY = false;
IChannel _channel;
string _exchangeName = null;
Re: svn commit: r605536 - /incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
Posted by Rupert Smith <ru...@googlemail.com>.
Yes, 714 will apply to the .Net:
internal void AcknowledgeLastDelivered()
{
if (_lastDeliveryTag > 0)
{
_channel.AcknowledgeMessage((ulong)_lastDeliveryTag, true);
// XXX evil cast
_lastDeliveryTag = -1;
}
}
Called when committing, and acks up to the last tag.
Rupert
On 04/01/2008, Aidan Skinner <ai...@gmail.com> wrote:
>
> On Jan 4, 2008 10:19 AM, Rupert Smith <ru...@googlemail.com>
> wrote:
>
> > It does not send mandatory by default whereas before it did. I thought
> we
> > had decided that this was how the Java is to do it too? If not I can
> change
> > it back.
> >
> > Reason I changed it was because the error handling in the .Net is broken
> > (bug introduced when I fixed fail-over), and returned messages cause it
> to
> > break. I should really fix that properly too.
>
> On a related note, did we determine if QPID-714 applys to the .Net
> client as well?
>
> - Aidan
> --
> aim/y!:aidans42 g:aidan.skinner@gmail.com
> http://aidan.skinner.me.uk/
> "When the going gets weird, the weird turn pro."
> -- Hunter S. Thompson
>
Re: svn commit: r605536 - /incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
Posted by Aidan Skinner <ai...@gmail.com>.
On Jan 4, 2008 10:19 AM, Rupert Smith <ru...@googlemail.com> wrote:
> It does not send mandatory by default whereas before it did. I thought we
> had decided that this was how the Java is to do it too? If not I can change
> it back.
>
> Reason I changed it was because the error handling in the .Net is broken
> (bug introduced when I fixed fail-over), and returned messages cause it to
> break. I should really fix that properly too.
On a related note, did we determine if QPID-714 applys to the .Net
client as well?
- Aidan
--
aim/y!:aidans42 g:aidan.skinner@gmail.com
http://aidan.skinner.me.uk/
"When the going gets weird, the weird turn pro."
-- Hunter S. Thompson
Re: svn commit: r605536 - /incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
Posted by Rupert Smith <ru...@googlemail.com>.
It does not send mandatory by default whereas before it did. I thought we
had decided that this was how the Java is to do it too? If not I can change
it back.
Reason I changed it was because the error handling in the .Net is broken
(bug introduced when I fixed fail-over), and returned messages cause it to
break. I should really fix that properly too.
Rupert
On 31/12/2007, Martin Ritchie <ri...@apache.org> wrote:
>
> Just catching up with all the goings on over the Festive period.
>
> Rupert, why are we making the .NET not send Mandatory messages? Is
> there are similar change to be done to the other clients?
>
> On 19/12/2007, rupertlssmith@apache.org <ru...@apache.org> wrote:
> > Author: rupertlssmith
> > Date: Wed Dec 19 05:40:05 2007
> > New Revision: 605536
> >
> > URL: http://svn.apache.org/viewvc?rev=605536&view=rev
> > Log:
> > Messages were being sent mandatory by default, set to false.
> >
> > Modified:
> >
> incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
> >
> > Modified:
> incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
> > URL:
> http://svn.apache.org/viewvc/incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs?rev=605536&r1=605535&r2=605536&view=diff
> >
> ==============================================================================
> > ---
> incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
> (original)
> > +++
> incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
> Wed Dec 19 05:40:05 2007
> > @@ -31,7 +31,7 @@
> > /// Default value for mandatory flag is true, i.e. server will
> not silently drop messages where no queue is
> > /// connected to the exchange for the message
> > /// </summary>
> > - const bool DEFAULT_MANDATORY = true;
> > + const bool DEFAULT_MANDATORY = false;
> >
> > IChannel _channel;
> > string _exchangeName = null;
> >
> >
> >
>
>
> --
> Martin Ritchie
>
Re: svn commit: r605536 - /incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
Posted by Martin Ritchie <ri...@apache.org>.
Just catching up with all the goings on over the Festive period.
Rupert, why are we making the .NET not send Mandatory messages? Is
there are similar change to be done to the other clients?
On 19/12/2007, rupertlssmith@apache.org <ru...@apache.org> wrote:
> Author: rupertlssmith
> Date: Wed Dec 19 05:40:05 2007
> New Revision: 605536
>
> URL: http://svn.apache.org/viewvc?rev=605536&view=rev
> Log:
> Messages were being sent mandatory by default, set to false.
>
> Modified:
> incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
>
> Modified: incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs
> URL: http://svn.apache.org/viewvc/incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs?rev=605536&r1=605535&r2=605536&view=diff
> ==============================================================================
> --- incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs (original)
> +++ incubator/qpid/branches/M2.1.1/dotnet/Qpid.Messaging/MessagePublisherBuilder.cs Wed Dec 19 05:40:05 2007
> @@ -31,7 +31,7 @@
> /// Default value for mandatory flag is true, i.e. server will not silently drop messages where no queue is
> /// connected to the exchange for the message
> /// </summary>
> - const bool DEFAULT_MANDATORY = true;
> + const bool DEFAULT_MANDATORY = false;
>
> IChannel _channel;
> string _exchangeName = null;
>
>
>
--
Martin Ritchie