You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "platoneko (via GitHub)" <gi...@apache.org> on 2023/12/20 08:01:17 UTC

[PR] [enhance](tablet) Reduce log in tablet meta [doris]

platoneko opened a new pull request, #28719:
URL: https://github.com/apache/doris/pull/28719

   ## Proposed changes
   
   Reduce log in tablet meta
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1864637142

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1865397678

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1865412295

   TeamCity be ut coverage result:
    Function Coverage: 36.48% (8537/23405) 
    Line Coverage: 28.59% (69411/242749)
    Region Coverage: 27.62% (35920/130064)
    Branch Coverage: 24.36% (18357/75364)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/12d124e3130022a2c0d90649c10ccd353f7fc203_12d124e3130022a2c0d90649c10ccd353f7fc203/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1864055392

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1864026859

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1865393473

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1864069322

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.02 seconds
    stream load tsv:          584 seconds loaded 74807831229 Bytes, about 122 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          33 seconds loaded 861443392 Bytes, about 24 MB/s
    insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
    storage size: 17184029740 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1864049741

   TeamCity be ut coverage result:
    Function Coverage: 36.47% (8534/23397) 
    Line Coverage: 28.60% (69379/242550)
    Region Coverage: 27.63% (35905/129948)
    Branch Coverage: 24.37% (18349/75302)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/8f0e7a3ed20d473312edd7f74aad0f59162ca6ab_8f0e7a3ed20d473312edd7f74aad0f59162ca6ab/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1865413756

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit 12d124e3130022a2c0d90649c10ccd353f7fc203, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4710	4408	4488	4408
   q2	371	148	161	148
   q3	1481	1278	1208	1208
   q4	1114	923	870	870
   q5	3134	3187	3199	3187
   q6	251	127	127	127
   q7	1014	500	501	500
   q8	2209	2223	2204	2204
   q9	6703	6711	6721	6711
   q10	3238	3300	3304	3300
   q11	311	196	192	192
   q12	359	213	211	211
   q13	4579	3849	3803	3803
   q14	248	213	217	213
   q15	569	519	520	519
   q16	453	395	392	392
   q17	1010	569	538	538
   q18	7197	6836	7028	6836
   q19	1521	1377	1421	1377
   q20	557	306	303	303
   q21	3040	2679	2664	2664
   q22	366	302	305	302
   Total cold run time: 44435 ms
   Total hot run time: 40013 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4389	4380	4400	4380
   q2	274	167	180	167
   q3	3547	3532	3538	3532
   q4	2406	2406	2387	2387
   q5	5746	5770	5775	5770
   q6	243	122	124	122
   q7	2388	1910	1879	1879
   q8	3532	3534	3534	3534
   q9	9085	9043	9017	9017
   q10	3932	4002	4008	4002
   q11	492	377	381	377
   q12	779	598	606	598
   q13	4293	3557	3589	3557
   q14	282	249	265	249
   q15	581	534	526	526
   q16	520	456	518	456
   q17	1896	1871	1870	1870
   q18	8687	8117	8395	8117
   q19	1756	1741	1761	1741
   q20	2279	1989	1965	1965
   q21	6600	6244	6258	6244
   q22	518	442	448	442
   Total cold run time: 64225 ms
   Total hot run time: 60932 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1864643142

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1864106775

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit 8f0e7a3ed20d473312edd7f74aad0f59162ca6ab, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4736	4474	4439	4439
   q2	361	150	161	150
   q3	1460	1258	1279	1258
   q4	1115	884	854	854
   q5	3152	3135	3171	3135
   q6	251	126	125	125
   q7	1017	481	491	481
   q8	2219	2212	2198	2198
   q9	6683	6677	6680	6677
   q10	3218	3252	3284	3252
   q11	306	188	187	187
   q12	344	211	201	201
   q13	4556	3819	3799	3799
   q14	236	212	218	212
   q15	573	528	531	528
   q16	435	393	383	383
   q17	1001	595	589	589
   q18	7105	6920	6991	6920
   q19	1519	1370	1394	1370
   q20	524	310	291	291
   q21	3063	2697	2619	2619
   q22	349	294	287	287
   Total cold run time: 44223 ms
   Total hot run time: 39955 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4361	4337	4335	4335
   q2	270	168	175	168
   q3	3533	3517	3513	3513
   q4	2379	2387	2379	2379
   q5	5768	5741	5742	5741
   q6	242	120	121	120
   q7	2370	1868	1862	1862
   q8	3525	3515	3535	3515
   q9	9033	8998	8989	8989
   q10	3928	4034	4037	4034
   q11	485	386	375	375
   q12	765	589	604	589
   q13	4308	3586	3543	3543
   q14	285	271	258	258
   q15	573	527	526	526
   q16	521	462	474	462
   q17	1903	1871	1873	1871
   q18	8552	8287	8155	8155
   q19	1712	1765	1753	1753
   q20	2254	1944	1925	1925
   q21	6526	6231	6184	6184
   q22	527	437	428	428
   Total cold run time: 63820 ms
   Total hot run time: 60725 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28719:
URL: https://github.com/apache/doris/pull/28719#issuecomment-1865420790

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 43.64 seconds
    stream load tsv:          567 seconds loaded 74807831229 Bytes, about 125 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
    storage size: 17184142422 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [enhance](tablet) Reduce log in tablet meta [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #28719:
URL: https://github.com/apache/doris/pull/28719


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org