DO NOT REPLY [Bug 29712] New: - Incomplete fileuploads are not deleted

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29712>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29712

Incomplete fileuploads are not deleted

           Summary: Incomplete fileuploads are not deleted
           Product: Cocoon 2
           Version: Current CVS 2.1
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: core
        AssignedTo: dev@cocoon.apache.org
        ReportedBy: g.brand@interface-business.de


If a user uploads a multipart encoded form containing files and aborts the 
submit, partially uploaded files are not deleted and stay in the upload dir. 
Also the outputstream used to write to the particular file is not closed due to 
a missing try/finally block.

I am appending a patch that fixes those two issues.

It does _not_ fix the problem of two or more files being uploaded, one or more 
of these files being complete and then the submit being aborted during the 
upload of the 2nd+ file. In this case the complete file(s) will still sit in 
the upload dir. I haven't really looked into it but they most likely need to 
deleted in the MultipartParser constructor in a catch block. Unless somebody 
outside the scope of the parser deletes them. They are properly stored in the 
parts map.

ps: the MultipartParser.java contains quite a number of tabulator characters.