You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Archana H <ar...@gmail.com> on 2016/06/02 07:52:04 UTC
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/
-----------------------------------------------------------
(Updated June 2, 2016, 7:52 a.m.)
Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
Summary (updated)
-----------------
LENS-1148 : Throttling tests to regression
Repository: lens
Description
-------
Throttling tests to regression
Diffs
-----
lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
Diff: https://reviews.apache.org/r/47593/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
[INFO] Lens .............................................. SUCCESS [3.553s]
[INFO] Lens API .......................................... SUCCESS [20.758s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
[INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
[INFO] Lens DB storage ................................... SUCCESS [17.028s]
[INFO] Lens Query Library ................................ SUCCESS [18.060s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
[INFO] Lens Server ....................................... SUCCESS [8:49.961s]
[INFO] Lens client ....................................... SUCCESS [1:29.573s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
[INFO] Lens Examples ..................................... SUCCESS [7.455s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
[INFO] Lens Distribution ................................. SUCCESS [9.060s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
[INFO] Lens Regression ................................... SUCCESS [11.454s]
[INFO] Lens UI ........................................... SUCCESS [27.047s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:41.125s
[INFO] Finished at: Thu May 19 11:53:17 UTC 2016
[INFO] Final Memory: 186M/2279M
[INFO] ------------------------------------------------------------------------
Thanks,
Archana H
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/#review136218
-----------------------------------------------------------
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (lines 208 - 211)
<https://reviews.apache.org/r/47593/#comment201232>
Should we add a comment in code as to why this behaviour is expected. This is help new developers(and sometimes users) understand the system better. In general we can add more comments to test cases for the same reason.
- Puneet Gupta
On June 2, 2016, 8:40 a.m., Archana H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47593/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 8:40 a.m.)
>
>
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Throttling tests to regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml b9bee97
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
> lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
> lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
> lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47593/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
> [INFO] Lens .............................................. SUCCESS [3.553s]
> [INFO] Lens API .......................................... SUCCESS [20.758s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
> [INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.028s]
> [INFO] Lens Query Library ................................ SUCCESS [18.060s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
> [INFO] Lens Server ....................................... SUCCESS [8:49.961s]
> [INFO] Lens client ....................................... SUCCESS [1:29.573s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
> [INFO] Lens Examples ..................................... SUCCESS [7.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
> [INFO] Lens Distribution ................................. SUCCESS [9.060s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
> [INFO] Lens Regression ................................... SUCCESS [11.454s]
> [INFO] Lens UI ........................................... SUCCESS [27.047s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:41.125s
> [INFO] Finished at: Thu May 19 11:53:17 UTC 2016
> [INFO] Final Memory: 186M/2279M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Archana H
>
>
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Archana H <ar...@gmail.com>.
> On June 6, 2016, 5:03 a.m., Puneet Gupta wrote:
> > lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java, lines 292-295
> > <https://reviews.apache.org/r/47593/diff/2/?file=1404592#file1404592line292>
> >
> > Should we remove this check ? queued and running list is empty already .
Sometimes last few queries will still be running even after coming out of for loop. (case when queries are moving from queue to running)
- Archana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/#review136222
-----------------------------------------------------------
On June 2, 2016, 8:40 a.m., Archana H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47593/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 8:40 a.m.)
>
>
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Throttling tests to regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml b9bee97
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
> lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
> lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
> lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47593/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
> [INFO] Lens .............................................. SUCCESS [3.553s]
> [INFO] Lens API .......................................... SUCCESS [20.758s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
> [INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.028s]
> [INFO] Lens Query Library ................................ SUCCESS [18.060s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
> [INFO] Lens Server ....................................... SUCCESS [8:49.961s]
> [INFO] Lens client ....................................... SUCCESS [1:29.573s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
> [INFO] Lens Examples ..................................... SUCCESS [7.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
> [INFO] Lens Distribution ................................. SUCCESS [9.060s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
> [INFO] Lens Regression ................................... SUCCESS [11.454s]
> [INFO] Lens UI ........................................... SUCCESS [27.047s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:41.125s
> [INFO] Finished at: Thu May 19 11:53:17 UTC 2016
> [INFO] Final Memory: 186M/2279M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Archana H
>
>
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/#review136222
-----------------------------------------------------------
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 51)
<https://reviews.apache.org/r/47593/#comment201246>
Worried about the total run time of the test cases in this class. Can you share the run times ?
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (lines 236 - 238)
<https://reviews.apache.org/r/47593/#comment201240>
We are passing only low and verylow configration. Do we need to pass high and normal also ?
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 267)
<https://reviews.apache.org/r/47593/#comment201243>
Priority should never be null. Should we fail the test case if it is ?
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 268)
<https://reviews.apache.org/r/47593/#comment201244>
Is COST_20 will be NORMAL priority ? If yes we need to count normals also.
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (lines 275 - 277)
<https://reviews.apache.org/r/47593/#comment201245>
It will be better to have a default case where we can fail the test case incase we get an unexpected value for priority.
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (lines 292 - 295)
<https://reviews.apache.org/r/47593/#comment201247>
Should we remove this check ? queued and running list is empty already .
- Puneet Gupta
On June 2, 2016, 8:40 a.m., Archana H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47593/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 8:40 a.m.)
>
>
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Throttling tests to regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml b9bee97
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
> lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
> lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
> lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47593/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
> [INFO] Lens .............................................. SUCCESS [3.553s]
> [INFO] Lens API .......................................... SUCCESS [20.758s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
> [INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.028s]
> [INFO] Lens Query Library ................................ SUCCESS [18.060s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
> [INFO] Lens Server ....................................... SUCCESS [8:49.961s]
> [INFO] Lens client ....................................... SUCCESS [1:29.573s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
> [INFO] Lens Examples ..................................... SUCCESS [7.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
> [INFO] Lens Distribution ................................. SUCCESS [9.060s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
> [INFO] Lens Regression ................................... SUCCESS [11.454s]
> [INFO] Lens UI ........................................... SUCCESS [27.047s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:41.125s
> [INFO] Finished at: Thu May 19 11:53:17 UTC 2016
> [INFO] Final Memory: 186M/2279M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Archana H
>
>
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Archana H <ar...@gmail.com>.
> On June 6, 2016, 5:30 a.m., Puneet Gupta wrote:
> > lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java, line 449
> > <https://reviews.apache.org/r/47593/diff/2/?file=1404592#file1404592line449>
> >
> > Should we rename priority1,2 to low and verylow?
If we want to put filter on any other priorty, then name will conflict, hence kept the generic name.
> On June 6, 2016, 5:30 a.m., Puneet Gupta wrote:
> > lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java, lines 509-512
> > <https://reviews.apache.org/r/47593/diff/2/?file=1404592#file1404592line509>
> >
> > Can we also assert totalrunning <= maxConcurrent
Its done just after getting runing and queued count.
> On June 6, 2016, 5:30 a.m., Puneet Gupta wrote:
> > lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java, lines 331-335
> > <https://reviews.apache.org/r/47593/diff/2/?file=1404592#file1404592line331>
> >
> > Should we chcek if queries 1 and 4 have started running after this ?
Checking for the same.
On June 6, 2016, 5:30 a.m., Archana H wrote:
> > Are we adding usercost based throttling tests cases separately ?
Yes. Few of them are added in ITCostsTests. Will add more usercost related to that.
- Archana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/#review136223
-----------------------------------------------------------
On June 2, 2016, 8:40 a.m., Archana H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47593/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 8:40 a.m.)
>
>
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Throttling tests to regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml b9bee97
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
> lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
> lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
> lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47593/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
> [INFO] Lens .............................................. SUCCESS [3.553s]
> [INFO] Lens API .......................................... SUCCESS [20.758s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
> [INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.028s]
> [INFO] Lens Query Library ................................ SUCCESS [18.060s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
> [INFO] Lens Server ....................................... SUCCESS [8:49.961s]
> [INFO] Lens client ....................................... SUCCESS [1:29.573s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
> [INFO] Lens Examples ..................................... SUCCESS [7.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
> [INFO] Lens Distribution ................................. SUCCESS [9.060s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
> [INFO] Lens Regression ................................... SUCCESS [11.454s]
> [INFO] Lens UI ........................................... SUCCESS [27.047s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:41.125s
> [INFO] Finished at: Thu May 19 11:53:17 UTC 2016
> [INFO] Final Memory: 186M/2279M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Archana H
>
>
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/#review136223
-----------------------------------------------------------
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (lines 331 - 335)
<https://reviews.apache.org/r/47593/#comment201249>
Should we chcek if queries 1 and 4 have started running after this ?
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 401)
<https://reviews.apache.org/r/47593/#comment201250>
This may not be needed at this point.
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 408)
<https://reviews.apache.org/r/47593/#comment201252>
+1. The test is simulating the real scenario very closely.
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 449)
<https://reviews.apache.org/r/47593/#comment201253>
Should we rename priority1,2 to low and verylow?
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (lines 509 - 512)
<https://reviews.apache.org/r/47593/#comment201254>
Can we also assert totalrunning <= maxConcurrent
Are we adding usercost based throttling tests cases separately ?
- Puneet Gupta
On June 2, 2016, 8:40 a.m., Archana H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47593/
> -----------------------------------------------------------
>
> (Updated June 2, 2016, 8:40 a.m.)
>
>
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Throttling tests to regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml b9bee97
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
> lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
> lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
> lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47593/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
> [INFO] Lens .............................................. SUCCESS [3.553s]
> [INFO] Lens API .......................................... SUCCESS [20.758s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
> [INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.028s]
> [INFO] Lens Query Library ................................ SUCCESS [18.060s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
> [INFO] Lens Server ....................................... SUCCESS [8:49.961s]
> [INFO] Lens client ....................................... SUCCESS [1:29.573s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
> [INFO] Lens Examples ..................................... SUCCESS [7.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
> [INFO] Lens Distribution ................................. SUCCESS [9.060s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
> [INFO] Lens Regression ................................... SUCCESS [11.454s]
> [INFO] Lens UI ........................................... SUCCESS [27.047s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:41.125s
> [INFO] Finished at: Thu May 19 11:53:17 UTC 2016
> [INFO] Final Memory: 186M/2279M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Archana H
>
>
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/#review136629
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On June 8, 2016, 8:43 a.m., Archana H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47593/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 8:43 a.m.)
>
>
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Throttling tests to regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml b9bee97
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
> lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
> lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
> lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47593/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
> [INFO] Lens .............................................. SUCCESS [3.553s]
> [INFO] Lens API .......................................... SUCCESS [20.758s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
> [INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.028s]
> [INFO] Lens Query Library ................................ SUCCESS [18.060s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
> [INFO] Lens Server ....................................... SUCCESS [8:49.961s]
> [INFO] Lens client ....................................... SUCCESS [1:29.573s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
> [INFO] Lens Examples ..................................... SUCCESS [7.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
> [INFO] Lens Distribution ................................. SUCCESS [9.060s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
> [INFO] Lens Regression ................................... SUCCESS [11.454s]
> [INFO] Lens UI ........................................... SUCCESS [27.047s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:41.125s
> [INFO] Finished at: Thu May 19 11:53:17 UTC 2016
> [INFO] Final Memory: 186M/2279M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Archana H
>
>
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Archana H <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/
-----------------------------------------------------------
(Updated June 8, 2016, 8:43 a.m.)
Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
Changes
-------
review comment changes
Repository: lens
Description
-------
Throttling tests to regression
Diffs (updated)
-----
lens-regression/pom.xml b9bee97
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
Diff: https://reviews.apache.org/r/47593/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
[INFO] Lens .............................................. SUCCESS [3.553s]
[INFO] Lens API .......................................... SUCCESS [20.758s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
[INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
[INFO] Lens DB storage ................................... SUCCESS [17.028s]
[INFO] Lens Query Library ................................ SUCCESS [18.060s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
[INFO] Lens Server ....................................... SUCCESS [8:49.961s]
[INFO] Lens client ....................................... SUCCESS [1:29.573s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
[INFO] Lens Examples ..................................... SUCCESS [7.455s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
[INFO] Lens Distribution ................................. SUCCESS [9.060s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
[INFO] Lens Regression ................................... SUCCESS [11.454s]
[INFO] Lens UI ........................................... SUCCESS [27.047s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:41.125s
[INFO] Finished at: Thu May 19 11:53:17 UTC 2016
[INFO] Final Memory: 186M/2279M
[INFO] ------------------------------------------------------------------------
Thanks,
Archana H
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Archana H <ar...@gmail.com>.
> On June 8, 2016, 1:56 a.m., Puneet Gupta wrote:
> > lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java, line 511
> > <https://reviews.apache.org/r/47593/diff/3/?file=1408203#file1408203line511>
> >
> > Can we remove null check and add a final else fail("Unexpected Priority").
Firing queries which have priority other than low and very_low as well, so can't put else fail ("unexpected prioirty")
> On June 8, 2016, 1:56 a.m., Puneet Gupta wrote:
> > lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java, line 519
> > <https://reviews.apache.org/r/47593/diff/3/?file=1408203#file1408203line519>
> >
> > can we add a final else fail("Unexpected Queue").
Firing queries with default queue as well, so can't put else fail ("unexpected queue")
- Archana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/#review136578
-----------------------------------------------------------
On June 7, 2016, 6:33 a.m., Archana H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47593/
> -----------------------------------------------------------
>
> (Updated June 7, 2016, 6:33 a.m.)
>
>
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Throttling tests to regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml b9bee97
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
> lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
> lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
> lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47593/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
> [INFO] Lens .............................................. SUCCESS [3.553s]
> [INFO] Lens API .......................................... SUCCESS [20.758s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
> [INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.028s]
> [INFO] Lens Query Library ................................ SUCCESS [18.060s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
> [INFO] Lens Server ....................................... SUCCESS [8:49.961s]
> [INFO] Lens client ....................................... SUCCESS [1:29.573s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
> [INFO] Lens Examples ..................................... SUCCESS [7.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
> [INFO] Lens Distribution ................................. SUCCESS [9.060s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
> [INFO] Lens Regression ................................... SUCCESS [11.454s]
> [INFO] Lens UI ........................................... SUCCESS [27.047s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:41.125s
> [INFO] Finished at: Thu May 19 11:53:17 UTC 2016
> [INFO] Final Memory: 186M/2279M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Archana H
>
>
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/#review136578
-----------------------------------------------------------
Fix it, then Ship it!
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 209)
<https://reviews.apache.org/r/47593/#comment201667>
Can we update the comment
1. cost_95 is very low priority query
2. cost_20 and cost_60 goes to running as they are normal and low priority queries and there is no limit set for low and normal priority queries .
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 511)
<https://reviews.apache.org/r/47593/#comment201668>
Can we remove null check and add a final else fail("Unexpected Priority").
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java (line 519)
<https://reviews.apache.org/r/47593/#comment201669>
can we add a final else fail("Unexpected Queue").
- Puneet Gupta
On June 7, 2016, 6:33 a.m., Archana H wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47593/
> -----------------------------------------------------------
>
> (Updated June 7, 2016, 6:33 a.m.)
>
>
> Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Throttling tests to regression
>
>
> Diffs
> -----
>
> lens-regression/pom.xml b9bee97
> lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
> lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
> lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
> lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47593/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
> [INFO] Lens .............................................. SUCCESS [3.553s]
> [INFO] Lens API .......................................... SUCCESS [20.758s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
> [INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.028s]
> [INFO] Lens Query Library ................................ SUCCESS [18.060s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
> [INFO] Lens Server ....................................... SUCCESS [8:49.961s]
> [INFO] Lens client ....................................... SUCCESS [1:29.573s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
> [INFO] Lens Examples ..................................... SUCCESS [7.455s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
> [INFO] Lens Distribution ................................. SUCCESS [9.060s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
> [INFO] Lens Regression ................................... SUCCESS [11.454s]
> [INFO] Lens UI ........................................... SUCCESS [27.047s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:41.125s
> [INFO] Finished at: Thu May 19 11:53:17 UTC 2016
> [INFO] Final Memory: 186M/2279M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Archana H
>
>
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Archana H <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/
-----------------------------------------------------------
(Updated June 7, 2016, 6:33 a.m.)
Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
Changes
-------
review comment changes
Repository: lens
Description
-------
Throttling tests to regression
Diffs (updated)
-----
lens-regression/pom.xml b9bee97
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
Diff: https://reviews.apache.org/r/47593/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
[INFO] Lens .............................................. SUCCESS [3.553s]
[INFO] Lens API .......................................... SUCCESS [20.758s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
[INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
[INFO] Lens DB storage ................................... SUCCESS [17.028s]
[INFO] Lens Query Library ................................ SUCCESS [18.060s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
[INFO] Lens Server ....................................... SUCCESS [8:49.961s]
[INFO] Lens client ....................................... SUCCESS [1:29.573s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
[INFO] Lens Examples ..................................... SUCCESS [7.455s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
[INFO] Lens Distribution ................................. SUCCESS [9.060s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
[INFO] Lens Regression ................................... SUCCESS [11.454s]
[INFO] Lens UI ........................................... SUCCESS [27.047s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:41.125s
[INFO] Finished at: Thu May 19 11:53:17 UTC 2016
[INFO] Final Memory: 186M/2279M
[INFO] ------------------------------------------------------------------------
Thanks,
Archana H
Re: Review Request 47593: LENS-1148 : Throttling tests to regression
Posted by Archana H <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47593/
-----------------------------------------------------------
(Updated June 2, 2016, 8:40 a.m.)
Review request for lens, Deepak Barr, Rajat Khandelwal, and Puneet Gupta.
Changes
-------
review comment changes
Repository: lens
Description
-------
Throttling tests to regression
Diffs (updated)
-----
lens-regression/pom.xml b9bee97
lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 1a538da
lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java e588c1b
lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java 4da4c3a
lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java PRE-CREATION
Diff: https://reviews.apache.org/r/47593/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.563s]
[INFO] Lens .............................................. SUCCESS [3.553s]
[INFO] Lens API .......................................... SUCCESS [20.758s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.842s]
[INFO] Lens Cube ......................................... SUCCESS [14:01.494s]
[INFO] Lens DB storage ................................... SUCCESS [17.028s]
[INFO] Lens Query Library ................................ SUCCESS [18.060s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:33.480s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.171s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [23.389s]
[INFO] Lens Server ....................................... SUCCESS [8:49.961s]
[INFO] Lens client ....................................... SUCCESS [1:29.573s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.608s]
[INFO] Lens Examples ..................................... SUCCESS [7.455s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.671s]
[INFO] Lens Distribution ................................. SUCCESS [9.060s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:09.787s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.321s]
[INFO] Lens Regression ................................... SUCCESS [11.454s]
[INFO] Lens UI ........................................... SUCCESS [27.047s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:41.125s
[INFO] Finished at: Thu May 19 11:53:17 UTC 2016
[INFO] Final Memory: 186M/2279M
[INFO] ------------------------------------------------------------------------
Thanks,
Archana H