You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by ganeshchand <gi...@git.apache.org> on 2017/10/30 20:55:09 UTC

[GitHub] spark pull request #19613: Fixed a typo

GitHub user ganeshchand opened a pull request:

    https://github.com/apache/spark/pull/19613

    Fixed a typo

    ready to serialized => ready to be serialized
    
    ## What changes were proposed in this pull request?
    
    (Please fill in changes proposed in this fix)
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
    (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ganeshchand/spark patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19613.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19613
    
----
commit 6e086a38ccb32a04748a71bc23f1e65c383694b4
Author: Ganesh Chand <ga...@gmail.com>
Date:   2017-10-30T20:53:38Z

    Fixed a typo
    
    ready to serialized => ready to be serialized

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19613: Fixed a typo

Posted by jmchung <gi...@git.apache.org>.

Github user jmchung commented on the issue:

    https://github.com/apache/spark/pull/19613
  
    Hi @ganeshchand , could you also fix the typo in `JdbcUtils.scala`? Thanks!
    #L459 underling => underlying


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19613: Fixed a typo

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19613
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19613: Fixed a typo

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19613
  
    Ping @ganeshchand to address whatever typos have been found to date or close


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19613: Fixed a typo

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19613
  
    Or in UnsafeArrayData, corrresponding -> corresponding
    If you just run a spell check of comments in an IDE, I'm sure a quick pass would reveal a lot of little typos. The more you are willing to fix in one pass, the better.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19613: Fixed a typo

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19613
  
    Close this if you're not going to update @ganeshchand 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19613: Fixed a typo

Posted by ganeshchand <gi...@git.apache.org>.

Github user ganeshchand commented on the issue:

    https://github.com/apache/spark/pull/19613
  
    @srowen, @jmchung  - I came across the typo while reading the source for this specific class. Yeah,  I agree with your suggestion on running spell checks and fix as much in one pass. I'll submit another PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19613: Fixed a typo

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/19613
  
    Just add to this one. Any additional typos you can pick up in a quick pass are helpful


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org