You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/12 11:26:53 UTC
[GitHub] [dolphinscheduler] retime123 opened a new pull request, #10017: Monitoring: Added disk available capacity monitoring
retime123 opened a new pull request, #10017:
URL: https://github.com/apache/dolphinscheduler/pull/10017
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
This method is added because the available disk capacity cannot be monitored
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
Change dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
Change dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HeartBeat.java
Change dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java
Change dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/master.vue
Change dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js
Change dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
I have test local
<!--*(Please pick either of the following options)*-->
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10017: Monitoring: Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10017:
URL: https://github.com/apache/dolphinscheduler/pull/10017#issuecomment-1126631375
Hi @retime123 , You should change your target branch from ```2.0.5-release``` to ```2.0.6-prepare``` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10017: Monitoring: Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10017:
URL: https://github.com/apache/dolphinscheduler/pull/10017#issuecomment-1125983664
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10017)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=BUG) [52 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=VULNERABILITY) [6 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=SECURITY_HOTSPOT) [11 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=CODE_SMELL) [1278 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10017&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10017&metric=new_coverage&view=list) [18.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10017&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10017&metric=new_duplicated_lines_density&view=list) [4.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10017&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] retime123 commented on pull request #10017: Monitoring: Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
retime123 commented on PR #10017:
URL: https://github.com/apache/dolphinscheduler/pull/10017#issuecomment-1125734713
The 2.0.5-Release branch that I just downloaded today has the same running result as the test result of the code I submitted. There should be a bug in the unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10017: Monitoring: Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10017:
URL: https://github.com/apache/dolphinscheduler/pull/10017#issuecomment-1125979041
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10017?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`2.0.5-release@d88656c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head 56f6a2c differs from pull request most recent head 18f5ba7. Consider uploading reports for the commit 18f5ba7 to get more accurate results
```diff
@@ Coverage Diff @@
## 2.0.5-release #10017 +/- ##
================================================
Coverage ? 21.06%
Complexity ? 1590
================================================
Files ? 536
Lines ? 22519
Branches ? 2666
================================================
Hits ? 4744
Misses ? 17292
Partials ? 483
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10017?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10017?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d88656c...18f5ba7](https://codecov.io/gh/apache/dolphinscheduler/pull/10017?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] retime123 commented on pull request #10017: Monitoring: Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
retime123 commented on PR #10017:
URL: https://github.com/apache/dolphinscheduler/pull/10017#issuecomment-1126013878
Can this code be merged? If not, what other adjustments need to be made?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org