You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by bd...@apache.org on 2019/05/06 14:44:47 UTC

[shiro] branch master updated: Add japicmp plugin to ensure semver compatibility

This is an automated email from the ASF dual-hosted git repository.

bdemers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shiro.git


The following commit(s) were added to refs/heads/master by this push:
     new 2ba194f  Add japicmp plugin to ensure semver compatibility
2ba194f is described below

commit 2ba194fce825ec22dfe9419a1da1fa8d68a45349
Author: Brian Demers <bd...@apache.org>
AuthorDate: Mon May 6 10:37:58 2019 -0400

    Add japicmp plugin to ensure semver compatibility
---
 integration-tests/pom.xml |  4 ++++
 pom.xml                   | 51 +++++++++++++++++++++++++++++++++++++++++++++++
 samples/pom.xml           |  4 ++++
 support/guice/pom.xml     |  4 ++++
 4 files changed, 63 insertions(+)

diff --git a/integration-tests/pom.xml b/integration-tests/pom.xml
index 04cc9d2..a684aae 100644
--- a/integration-tests/pom.xml
+++ b/integration-tests/pom.xml
@@ -34,6 +34,10 @@
     <description>Test for alternate major versions of dependencies</description>
     <packaging>pom</packaging>
 
+    <properties>
+        <japicmp.skip>true</japicmp.skip>
+    </properties>
+
     <modules>
         <module>support</module>
         <module>guice3</module>
diff --git a/pom.xml b/pom.xml
index de9b0f5..8961e6b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -66,6 +66,7 @@
 
     <properties>
 
+        <shiro.previousVersion>1.4.1</shiro.previousVersion>
         <!-- Replaced by the build number plugin at build time: -->
         <buildNumber>${user.name}-${maven.build.timestamp}</buildNumber>
 
@@ -363,6 +364,26 @@
                     <artifactId>dependency-check-maven</artifactId>
                     <version>4.0.0</version>
                 </plugin>
+                <plugin>
+                    <groupId>com.github.siom79.japicmp</groupId>
+                    <artifactId>japicmp-maven-plugin</artifactId>
+                    <version>0.13.0</version>
+                    <configuration>
+                        <oldVersion>
+                            <dependency>
+                                <groupId>${project.groupId}</groupId>
+                                <artifactId>${project.artifactId}</artifactId>
+                                <version>${shiro.previousVersion}</version>
+                                <type>jar</type>
+                            </dependency>
+                        </oldVersion>
+                        <parameter>
+                            <onlyModified>true</onlyModified>
+                            <breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
+                            <breakBuildBasedOnSemanticVersioning>true</breakBuildBasedOnSemanticVersioning>
+                        </parameter>
+                    </configuration>
+                </plugin>
             </plugins>
         </pluginManagement>
         <plugins>
@@ -1015,6 +1036,17 @@
             </dependency>
             <dependency>
                 <groupId>org.springframework</groupId>
+                <artifactId>spring-web</artifactId>
+                <version>${spring.version}</version>
+                <exclusions>
+                    <exclusion>
+                        <groupId>commons-logging</groupId>
+                        <artifactId>commons-logging</artifactId>
+                    </exclusion>
+                </exclusions>
+            </dependency>
+            <dependency>
+                <groupId>org.springframework</groupId>
                 <artifactId>spring-jdbc</artifactId>
                 <version>${spring.version}</version>
                 <optional>true</optional>
@@ -1382,5 +1414,24 @@
                 </plugins>
             </reporting>
         </profile>
+        <profile>
+            <id>ci</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>com.github.siom79.japicmp</groupId>
+                        <artifactId>japicmp-maven-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <id>japicmp</id>
+                                <goals>
+                                    <goal>cmp</goal>
+                                </goals>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
     </profiles>
 </project>
diff --git a/samples/pom.xml b/samples/pom.xml
index ef75847..ec38540 100644
--- a/samples/pom.xml
+++ b/samples/pom.xml
@@ -32,6 +32,10 @@
     <name>Apache Shiro :: Samples</name>
     <packaging>pom</packaging>
 
+    <properties>
+        <japicmp.skip>true</japicmp.skip>
+    </properties>
+
     <modules>
         <module>aspectj</module>
         <module>quickstart</module>
diff --git a/support/guice/pom.xml b/support/guice/pom.xml
index 62d35d0..87f6daf 100644
--- a/support/guice/pom.xml
+++ b/support/guice/pom.xml
@@ -31,6 +31,10 @@
     <name>Apache Shiro :: Support :: Guice</name>
     <packaging>bundle</packaging>
 
+    <properties>
+        <japicmp.skip>true</japicmp.skip>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.apache.shiro</groupId>