You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/05/05 23:04:57 UTC
Review Request 47046: The test code needs to be enhanced
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47046/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: geode-1183
https://issues.apache.org/jira/browse/geode-1183
Repository: geode
Description
-------
The test code is not mature enough. Sometimes it will fail when the primary is not yet setPrimary().
Diffs
-----
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java 684660b
Diff: https://reviews.apache.org/r/47046/diff/
Testing
-------
Thanks,
xiaojian zhou
Re: Review Request 47046: The test code needs to be enhanced
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47046/#review131963
-----------------------------------------------------------
Wait is deprecated. Use Awaitility.
And, looking it your code, I don't think it will ever recheck the condition. It's only going to set the vm0_proxy, vm1_proxy fields once.
- Dan Smith
On May 5, 2016, 11:04 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47046/
> -----------------------------------------------------------
>
> (Updated May 5, 2016, 11:04 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: geode-1183
> https://issues.apache.org/jira/browse/geode-1183
>
>
> Repository: geode
>
>
> Description
> -------
>
> The test code is not mature enough. Sometimes it will fail when the primary is not yet setPrimary().
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java 684660b
>
> Diff: https://reviews.apache.org/r/47046/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 47046: The test code needs to be enhanced
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47046/#review131976
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On May 5, 2016, 11:58 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47046/
> -----------------------------------------------------------
>
> (Updated May 5, 2016, 11:58 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: geode-1183
> https://issues.apache.org/jira/browse/geode-1183
>
>
> Repository: geode
>
>
> Description
> -------
>
> The test code is not mature enough. Sometimes it will fail when the primary is not yet setPrimary().
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java 684660b
>
> Diff: https://reviews.apache.org/r/47046/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 47046: The test code needs to be enhanced
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47046/
-----------------------------------------------------------
(Updated May 5, 2016, 11:58 p.m.)
Review request for geode and Dan Smith.
Changes
-------
a new version of fix
Bugs: geode-1183
https://issues.apache.org/jira/browse/geode-1183
Repository: geode
Description
-------
The test code is not mature enough. Sometimes it will fail when the primary is not yet setPrimary().
Diffs (updated)
-----
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java 684660b
Diff: https://reviews.apache.org/r/47046/diff/
Testing
-------
Thanks,
xiaojian zhou