[jira] [Comment Edited] (DRILL-3448) typo in QueryManager.DrillbitStatusListener will cause the Foreman to hang if a Drillbit dies

["Sudheesh Katkam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611187#comment-14611187 ] 

Sudheesh Katkam edited comment on DRILL-3448 at 7/1/15 11:38 PM:
-----------------------------------------------------------------

Let's file this case (where fragments on that drillbit finished successfully) as an another JIRA. There are other cases like DRILL-3030, which is how I found this issue in the first place. What say? Otherwise, your patch for DRILL-3167 might get too large.


was (Author: sudheeshkatkam):
Let's file this case as an another JIRA. There are other cases like DRILL-3030, which is how I found this issue in the first place. What say? Otherwise, your patch for DRILL-3167 might get too large.

> typo in QueryManager.DrillbitStatusListener will cause the Foreman to hang if a Drillbit dies
> ---------------------------------------------------------------------------------------------
>
>                 Key: DRILL-3448
>                 URL: https://issues.apache.org/jira/browse/DRILL-3448
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 1.0.0
>            Reporter: Deneche A. Hakim
>            Assignee: Deneche A. Hakim
>            Priority: Critical
>             Fix For: 1.2.0
>
>
> at the end of DrillbitStatusListener.drillbitUnregistered() there is if block:
> {code}
>       if (!atLeastOneFailure) {
>         logger.warn("...");
>         stateListener.moveToState(QueryState.FAILED,
>             new ForemanException(...));
>       }
> {code}
> this will basically fail the query if the drillbit DIDN'T contain any fragment for this Foreman, which in fact should be the inverse.
> I will most likely fix this as part of DRILL-3167 as I need to make changes to the listener.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)