You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/25 11:04:55 UTC

[GitHub] [pulsar] nicoloboschi opened a new pull request, #17282: [cleanup][owasp] Supress false positive netty-tcnative

nicoloboschi opened a new pull request, #17282:
URL: https://github.com/apache/pulsar/pull/17282

   ### Motivation
   Owasp check fails with 
   ```
   One or more dependencies were identified with known vulnerabilities in Pulsar :: Distribution :: Server:
   
   netty-tcnative-boringssl-static-2.0.52.Final-osx-x86_64.jar (pkg:maven/io.netty/netty-tcnative-boringssl-static@2.0.52.Final, cpe:2.3:a:chromium_project:chromium:2.0.52:*:*:*:*:*:*:*) : CVE-2011-1797
   
   ```
   
   It's clearly a false positive https://github.com/jeremylong/DependencyCheck/issues/4776
   
   ### Modifications
   
   * Suppress the violation
   
   - [x] `doc-not-needed` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] eolivelli merged pull request #17282: [cleanup][owasp] Supress false positive netty-tcnative

Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #17282:
URL: https://github.com/apache/pulsar/pull/17282


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17282: [cleanup][owasp] Supress false positive netty-tcnative

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17282:
URL: https://github.com/apache/pulsar/pull/17282#discussion_r955547469


##########
src/owasp-dependency-check-false-positives.xml:
##########
@@ -54,6 +54,13 @@
     <packageUrl regex="true">^pkg:maven/io\.netty/netty\-tcnative\-classes@.*$</packageUrl>
     <cpe>cpe:/a:netty:netty</cpe>
   </suppress>
+  <suppress>
+    <notes><![CDATA[
+   file name: netty-tcnative-boringssl-static-2.0.52.Final-osx-x86_64.jar
+   ]]></notes>
+    <sha1>87a933c786d4b38355ebbeea684ab48ae88ec265</sha1>
+    <cpe>cpe:/a:chromium_project:chromium</cpe>

Review Comment:
   ```
   2022-08-25T19:56:04.2775687Z [ERROR] Failed to execute goal org.owasp:dependency-check-maven:7.1.0:aggregate (default) on project pulsar: 
   2022-08-25T19:56:04.2776396Z [ERROR] 
   2022-08-25T19:56:04.2777027Z [ERROR] One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0': 
   2022-08-25T19:56:04.2777476Z [ERROR] 
   2022-08-25T19:56:04.2792695Z [ERROR] netty-tcnative-boringssl-static-2.0.52.Final-linux-x86_64.jar: CVE-2011-1797(9.3)
   ```
   
   There are still several failures. It seems related to os classfier. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on a diff in pull request #17282: [cleanup][owasp] Supress false positive netty-tcnative

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17282:
URL: https://github.com/apache/pulsar/pull/17282#discussion_r955547469


##########
src/owasp-dependency-check-false-positives.xml:
##########
@@ -54,6 +54,13 @@
     <packageUrl regex="true">^pkg:maven/io\.netty/netty\-tcnative\-classes@.*$</packageUrl>
     <cpe>cpe:/a:netty:netty</cpe>
   </suppress>
+  <suppress>
+    <notes><![CDATA[
+   file name: netty-tcnative-boringssl-static-2.0.52.Final-osx-x86_64.jar
+   ]]></notes>
+    <sha1>87a933c786d4b38355ebbeea684ab48ae88ec265</sha1>
+    <cpe>cpe:/a:chromium_project:chromium</cpe>

Review Comment:
   ```
   2022-08-25T19:56:04.2775687Z [ERROR] Failed to execute goal org.owasp:dependency-check-maven:7.1.0:aggregate (default) on project pulsar: 
   2022-08-25T19:56:04.2776396Z [ERROR] 
   2022-08-25T19:56:04.2777027Z [ERROR] One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0': 
   2022-08-25T19:56:04.2777476Z [ERROR] 
   2022-08-25T19:56:04.2792695Z [ERROR] netty-tcnative-boringssl-static-2.0.52.Final-linux-x86_64.jar: CVE-2011-1797(9.3)
   ```
   
   There are still several failures. It seems related to os classifier. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #17282: [cleanup][owasp] Supress false positive netty-tcnative

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17282:
URL: https://github.com/apache/pulsar/pull/17282#issuecomment-1229843954

   cc @codelipenghui @eolivelli we can merge this patch and unblock other patches touching dependencies.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #17282: [cleanup][owasp] Supress false positive netty-tcnative

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #17282:
URL: https://github.com/apache/pulsar/pull/17282#discussion_r955737357


##########
src/owasp-dependency-check-false-positives.xml:
##########
@@ -54,6 +54,13 @@
     <packageUrl regex="true">^pkg:maven/io\.netty/netty\-tcnative\-classes@.*$</packageUrl>
     <cpe>cpe:/a:netty:netty</cpe>
   </suppress>
+  <suppress>
+    <notes><![CDATA[
+   file name: netty-tcnative-boringssl-static-2.0.52.Final-osx-x86_64.jar
+   ]]></notes>
+    <sha1>87a933c786d4b38355ebbeea684ab48ae88ec265</sha1>
+    <cpe>cpe:/a:chromium_project:chromium</cpe>

Review Comment:
   @tisonkun yes it is. I added the regex instead of the sha to get all the different classifiers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org