You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/03/31 14:14:53 UTC
[GitHub] zeppelin pull request #2210: [ZEPPELIN-2088] Evaluate helium bundle one by o...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2210
[ZEPPELIN-2088] Evaluate helium bundle one by one
### What is this PR for?
Evaluate helium bundle one by one. Because
- Bundling them in one file is not good idea because the whole bundling fails if only one fails
- Some node packages might not installed correctly. For example, `amchart/amcharts3` will be install `helium-bundles/node_modules/my-helium-vis/node_modules` but `amchart-export` will be install `helium-bundles/node_modules` so `my-helium-vis` can't import `amchart-export`. (This is real case)
- Additionally, I used yarn to install requires node_modules. Since separated bundling mean installing dependencies for each helium package and `npm` is too slow for that.
- Install Zeppelin framework modules using [local path](https://docs.npmjs.com/files/package.json#local-paths). It's more safe and correct way to install local modules.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2088](https://issues.apache.org/jira/browse/ZEPPELIN-2088)
### How should this be tested?
1. Install any local helium package
2. Install any online helium package
3. Use them
4. Disable
5. Test `npm run dev:helium`
### Screenshots (if appropriate)
NONE
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2088/evaluate-helium-bundle-one-by-one
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2210.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2210
----
commit 0f8b6363ff30dc7dc8e028450d2af2ec7b96da6e
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-30T14:30:47Z
feat: Build each bundle using yarn
commit f2576b78518190a331cb3dcf70ef10351e2e3e68
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-30T20:50:41Z
feat: Build online packages
commit 2ea849298f8ee95bcfa29992857f85e28b3e2b0a
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-31T04:53:06Z
feat: enable, disable
commit 9fa2a2c6c775c8158af8ee526d3bf971a04b95a7
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-31T09:47:25Z
feat: Loading bundles
commit 94eaf3e19138fcd6b9e0cd0d7064bf21bc3a7a50
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-31T10:31:28Z
test: Fix APIs
commit f85110311d8620449144509c74b4f3d86e3371b2
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-31T10:40:52Z
fix: Log single bundle error to browser console
commit 80e52a8e487748783e368c9e532152fc4fdb2a02
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-31T13:18:12Z
fix: HeliumBundleFactoryTest
commit 586e2fd7da2daca8afa30e6c259b745104acb6d3
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-31T13:50:17Z
fix: Add nodeInstallationDir
commit bcd5bedf1df47308963532b664c04cc8b79be597
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-31T14:00:36Z
feat: Apply #2178
commit 84c4b793178d823f6d28d84b070c1e0fc97b0dbf
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-31T14:06:08Z
fix: Add error handling for failed bundle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2210
Great work.
Tested but I'm getting error on enabling package.
while master branch works without error on the same package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2210
Sorry for bothering. Fixed that issue and tested like
- remove `conf/heli.json` and `local-repo/helium-bundle`
- build and restart Zeppelin
- install any bundle (**test 1 to see `bundlePackage` works**)
- then remove `local-repo/helium-bundle`
- restart (**test 2 to see `bundleAllPackages` works)
- open other terminal and run `npm run dev:helium`
- modify your local package and refresh to see local package is updated (**test3**)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2210: [ZEPPELIN-2088] Bundle helium packages one by o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2210
Tested and LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2210
yeah I got same error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2210
Added summary to the PR description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2210: [ZEPPELIN-2088] Bundle helium packages one by one
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2210
Merge to master if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---