You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/02/15 14:40:47 UTC

[GitHub] [cordova-plugin-file] breautek opened a new pull request #458: refactor: shraed eslint config

breautek opened a new pull request #458:
URL: https://github.com/apache/cordova-plugin-file/pull/458


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   All
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Previous eslint install was not compatible with Node 14.
   Progresses https://github.com/apache/cordova/issues/223 & https://github.com/apache/cordova/issues/142
   
   ### Description
   <!-- Describe your changes in detail -->
   
   Removed local eslint install in favour of the shared eslint provided by `@cordova/eslint-config`
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   Ran `npm test`
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-file] breautek commented on pull request #458: refactor: shared eslint config

Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #458:
URL: https://github.com/apache/cordova-plugin-file/pull/458#issuecomment-780041871


   The failed check is due to an unrelated problem, which I'm going to solve in the WIP PR https://github.com/apache/cordova-plugin-file/pull/460
   
   Merging.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-file] breautek merged pull request #458: refactor: shared eslint config

Posted by GitBox <gi...@apache.org>.
breautek merged pull request #458:
URL: https://github.com/apache/cordova-plugin-file/pull/458


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org