You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/25 23:49:57 UTC

[GitHub] [apisix] nic-chen commented on a change in pull request #3125: docs: improve the plugin-develop doc

nic-chen commented on a change in pull request #3125:
URL: https://github.com/apache/apisix/pull/3125#discussion_r548923262



##########
File path: doc/plugin-develop.md
##########
@@ -106,33 +108,41 @@ $(INSTALL) apisix/plugins/skywalking/*.lua $(INST_LUADIR)/apisix/plugins/skywalk
 
 ## schema and check
 
-Write [Json Schema](https://json-schema.org) descriptions and check functions. similarly, take the key-auth plugin as an example to see its
+Write [Json Schema](https://json-schema.org) descriptions and check functions. Similarly, take the example-plugin plugin as an example to see its
  configuration data :
 
 ```json
- "key-auth" : {
-       "key" : "auth-one"
-  }
+"example-plugin" : {
+    i = 1,
+    s = "s",
+    t = {1}
+}

Review comment:
       it should be json here,not lua table ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org