[GitHub] [daffodil] mbeckerle commented on a diff in pull request #875: Remove all API deprecated methods/class/objects

[GitBox <gi...@apache.org>]

mbeckerle commented on code in PR #875:
URL: https://github.com/apache/daffodil/pull/875#discussion_r1022035674


##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala:
##########
@@ -825,50 +524,15 @@ class DataProcessor private[japi] (private var dp: SDataProcessor)
     val ur = dp.unparse(input, output).asInstanceOf[SUnparseResult]
     new UnparseResult(ur)
   }
-
-  /**
-   * Unparse a JDOM2 infoset
-   *
-   * @param output the byte channel to write the data to
-   * @param infoset the infoset to unparse, as a jdom event cursor
-   * @return an object with contains the result and/or diagnostic information
-   */
-  @deprecated("Use unparse(InfosetInputter, WritableByteChannel)", "2.0.0")
-  def unparse(output: WritableByteChannel, infoset: org.jdom2.Document): UnparseResult = {
-    val input = new JDOMInfosetInputter(infoset)
-    unparse(input, output)
-  }
 }
 
 /**
- * Result of calling [[DataProcessor#parse(java.nio.channels.ReadableByteChannel, InfosetOutputter, long)]], containing
+ * Result of calling [[DataProcessor#parse(InputSourceDataInputStream, InfosetOutputter)]], containing
  * the diagnostic information, and the final data location
  */
 class ParseResult private[japi] (pr: SParseResult, deprecatedOutput: Maybe[JDOMInfosetOutputter])
   extends WithDiagnostics(pr) {
 
-  /**

Review Comment:
   I suggest don't remove DFDL properties. Those are going to break old DFDL schemas. THey're not deprecated by us (Daffodil) but by the DFDL Standard Workgroup. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org