You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by James Mitchell <ja...@mac.com> on 2007/03/22 11:33:37 UTC
XWork build failing
Does XW trunk build for anyone else? When I try to build with Maven,
it fails on a few tests, but if I run those same tests within
Eclipse, they pass fine.
--
James Mitchell
The Ruby Roundup
http://www.rubyroundup.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Strange.
On my XP it seems to work.
D:\project\xwork>svn info
Path: .
URL: https://svn.opensymphony.com/svn/xwork/trunk
Repository Root: https://svn.opensymphony.com/svn/xwork
Repository UUID: e221344d-f017-0410-9bd5-d282ab1896d7
Revision: 1388
Node Kind: directory
Schedule: normal
Last Changed Author: phil
Last Changed Rev: 1388
Last Changed Date: 2007-03-16 09:25:46 +0100 (fr, 16 mar 2007)
mvn clean
mvn
Results :
Tests run: 180, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2 minutes 37 seconds
[INFO] Finished at: Fri Mar 23 10:00:13 CET 2007
[INFO] Final Memory: 11M/24M
[INFO] ------------------------------------------------------------------------
PS: It was slow building as it stopped during javadoc generation for about 1 min before continuing. At home it builds in 1 min.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135034#135034
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by James Mitchell <jm...@gmail.com>.
From XW trunk...
...
...
Mar 22, 2007 9:11:40 AM
org.springframework.beans.factory.support.DefaultListableBeanFactory
preInstantiateSingletons
INFO: Pre-instantiating singletons in factory
[org.springframework.beans.factory.support.DefaultListableBeanFactory
defining beans [spring-object-factory]; root of BeanFactory hierarchy]
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021
sec
Results :
Failed tests:
testTypeConversionError
(com.opensymphony.xwork2.util.OgnlValueStackTest)
testNoExceptionInSetForDefault
(com.opensymphony.xwork2.util.OgnlValueStackTest)
testObjectSettingWithInvalidValueDoesNotCauseSetCalledWithNull
(com.opensymphony.xwork2.util.OgnlValueStackTest)
testUsingDefaultInterceptorThatAliasPropertiesAreCopied
(com.opensymphony.xwork2.interceptor.AliasInterceptorTest)
Tests run: 518, Failures: 4, Errors: 0, Skipped: 0
[INFO]
------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] There are test failures.
[INFO]
------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 36 seconds
[INFO] Finished at: Thu Mar 22 09:11:40 EDT 2007
[INFO] Final Memory: 10M/32M
[INFO]
------------------------------------------------------------------------
[jmitchell@MBP17 ~/svn/struts/xwork]$ cat target/surefire-reports/
com.opensymphony.xwork2.interceptor.AliasInterceptorTest.txt
------------------------------------------------------------------------
-------
Test set: com.opensymphony.xwork2.interceptor.AliasInterceptorTest
------------------------------------------------------------------------
-------
Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.07
sec <<< FAILURE!
testUsingDefaultInterceptorThatAliasPropertiesAreCopied
(com.opensymphony.xwork2.interceptor.AliasInterceptorTest) Time
elapsed: 0.056 sec <<< FAILURE!
Error setting expression 'aliases' with value '#{ "aliasSource" :
"aliasDest", "bar":"baz" }' - [unknown location]
at com.opensymphony.xwork2.util.OgnlValueStack.setValue
(OgnlValueStack.java:171)
at com.opensymphony.xwork2.util.OgnlValueStack.setValue
(OgnlValueStack.java:146)
at
com.opensymphony.xwork2.interceptor.StaticParametersInterceptor.intercep
t(StaticParametersInterceptor.java:97)
at com.opensymphony.xwork2.DefaultActionInvocation
$2.doProfiling(DefaultActionInvocation.java:219)
at com.opensymphony.xwork2.DefaultActionInvocation
$2.doProfiling(DefaultActionInvocation.java:218)
at
com.opensymphony.xwork2.util.profiling.UtilTimerStack.profile
(UtilTimerStack.java:455)
at com.opensymphony.xwork2.DefaultActionInvocation.invoke
(DefaultActionInvocation.java:216)
at com.opensymphony.xwork2.DefaultActionProxy.execute
(DefaultActionProxy.java:133)
at
com.opensymphony.xwork2.interceptor.AliasInterceptorTest.testUsingDefaul
tInterceptorThatAliasPropertiesAreCopied(AliasInterceptorTest.java:45)
------------
If I comment that single test out, it fails on a different test in a
different class. And another, and another, up to about 4 tests and
then it's fine. Clearly something is different between my running
this in the console and what Eclipse is doing.
I've tried deleting .m2/repository/opensymphony/* and .m2/repository/
cglib/*, same error.
Anyone else seeing this?
--
James Mitchell
The Ruby Roundup
http://www.rubyroundup.com/
On Mar 22, 2007, at 6:53 AM, Philip Luppens wrote:
> What exceptions and what XW version ? There are some confusing
> problems with XW1_2 [1], but the others seem to run fine [2].
>
> Cheers,
>
> Phil
>
> [1] http://forums.opensymphony.com/thread.jspa?threadID=70501&tstart=0
> [2] http://opensource.bamboo.atlassian.com/browse/XWORK
>
>
> On 3/22/07, James Mitchell <ja...@mac.com> wrote:
>> Does XW trunk build for anyone else? When I try to build with Maven,
>> it fails on a few tests, but if I run those same tests within
>> Eclipse, they pass fine.
>>
>>
>> --
>> James Mitchell
>> The Ruby Roundup
>> http://www.rubyroundup.com/
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> --
> iDTV System Engineer
> "Always code as if the guy who ends up maintaining your code will be a
> violent psychopath who knows where you live." - John F. Woods
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Philip Luppens <ph...@gmail.com>.
What exceptions and what XW version ? There are some confusing
problems with XW1_2 [1], but the others seem to run fine [2].
Cheers,
Phil
[1] http://forums.opensymphony.com/thread.jspa?threadID=70501&tstart=0
[2] http://opensource.bamboo.atlassian.com/browse/XWORK
On 3/22/07, James Mitchell <ja...@mac.com> wrote:
> Does XW trunk build for anyone else? When I try to build with Maven,
> it fails on a few tests, but if I run those same tests within
> Eclipse, they pass fine.
>
>
> --
> James Mitchell
> The Ruby Roundup
> http://www.rubyroundup.com/
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
iDTV System Engineer
"Always code as if the guy who ends up maintaining your code will be a
violent psychopath who knows where you live." - John F. Woods
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Ted Husted <hu...@apache.org>.
The XW2 head is building under Maven here.
On 3/22/07, James Mitchell <ja...@mac.com> wrote:
> Does XW trunk build for anyone else? When I try to build with Maven,
> it fails on a few tests, but if I run those same tests within
> Eclipse, they pass fine.
>
>
> --
> James Mitchell
> The Ruby Roundup
> http://www.rubyroundup.com/
--
HTH, Ted <http://www.husted.com/ted/blog/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Piero Sartini <li...@pierosartini.de>.
Am Freitag, 23. März 2007 schrieb Ted Husted:
> On 3/23/07, Piero Sartini <li...@pierosartini.de> wrote:
> > Am Donnerstag, 22. März 2007 schrieb Claus Ibsen:
> > > Isn't it a unit test executed by surefire? that tests what happens if
> > > you do a XSLTransformation with an invalid filename, and thus it log it
> > > at ERROR level but the test is fine.
> >
> > But the test fails, and this should not happen I assume?
>
> It seems to be happening to some of us, but not to others.
>
> Claus and Ted are on XP. What are Piero and James using?
I am sorry - but I captured James' thread. He talked about xwork, my problem
is with s2. I misinterpreted the surefire output as well - please see my
answer to Claus what tests fail exactly.
Tried to build with Linux 2.6.20 and with Solaris (OpenSolaris b55)
However, on Solaris there are even more tests that fail.
Piero
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by James Mitchell <jm...@gmail.com>.
I'm on a MacBook Pro.
You can also look under target/surefire-reports/(test class).txt
--
James Mitchell
The Ruby Roundup
http://www.rubyroundup.com/
On Mar 23, 2007, at 11:29 AM, Ted Husted wrote:
> On 3/23/07, Piero Sartini <li...@pierosartini.de> wrote:
>> Am Donnerstag, 22. März 2007 schrieb Claus Ibsen:
>> > Isn't it a unit test executed by surefire? that tests what
>> happens if you
>> > do a XSLTransformation with an invalid filename, and thus it log
>> it at
>> > ERROR level but the test is fine.
>>
>> But the test fails, and this should not happen I assume?
>
> It seems to be happening to some of us, but not to others.
>
> Claus and Ted are on XP. What are Piero and James using?
>
> -Ted.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Ted Husted <hu...@apache.org>.
On 3/23/07, Piero Sartini <li...@pierosartini.de> wrote:
> Am Donnerstag, 22. März 2007 schrieb Claus Ibsen:
> > Isn't it a unit test executed by surefire? that tests what happens if you
> > do a XSLTransformation with an invalid filename, and thus it log it at
> > ERROR level but the test is fine.
>
> But the test fails, and this should not happen I assume?
It seems to be happening to some of us, but not to others.
Claus and Ted are on XP. What are Piero and James using?
-Ted.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Piero Sartini <li...@pierosartini.de>.
Ok, I checked it again and you are right. I assumed it is the XSLTResult
because it is the last error I see when the tests are finnished.
Actually, the errors are:
[surefire] Running org.apache.struts2.views.jsp.PortletUrlTagTest
[surefire] Tests run: 8, Failures: 1, Errors: 0, Time elapsed: 1,317 sec
<<<<<<<< FAILURE !!
and
[surefire] Running org.apache.struts2.views.jsp.URLTagTest
2007-03-23 18:01:22,906 WARN [URL.java:190] : Unknown value for includeParams
parameter to URL tag: unknown
[surefire] Tests run: 21, Failures: 7, Errors: 0, Time elapsed: 1,092 sec
<<<<<<<< FAILURE !!
Am Freitag, 23. März 2007 schrieb Claus Ibsen:
> Piero
>
> Are you sure surefire tests really fails. It reports something like <<<<<<<
> FAILURE in the output if it fails.
>
> The test can output logging at ERROR level and still not fail the test.
> Could you double check it and report back.
> ---------------------------------------------------------------------
> Posted via Jive Forums
> http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135233#
>135233
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Piero
Are you sure surefire tests really fails. It reports something like <<<<<<< FAILURE in the output if it fails.
The test can output logging at ERROR level and still not fail the test. Could you double check it and report back.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135233#135233
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Piero Sartini <li...@pierosartini.de>.
Am Donnerstag, 22. März 2007 schrieb Claus Ibsen:
> Isn't it a unit test executed by surefire? that tests what happens if you
> do a XSLTransformation with an invalid filename, and thus it log it at
> ERROR level but the test is fine.
But the test fails, and this should not happen I assume?
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] There are test failures.
> Try compiling without executing the tests with -Dskip.test=true or whatever
> the syntax is.
It works when bypassing -Dmaven.test.skip=true
But the issue remains: why does the test fail?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Isn't it a unit test executed by surefire? that tests what happens if you do a XSLTransformation with an invalid filename, and thus it log it at ERROR level but the test is fine.
Try compiling without executing the tests with -Dskip.test=true or whatever the syntax is.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=134727#134727
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Piero Sartini <li...@pierosartini.de>.
Dont know if this is related.
But I am unable to build s2 trunk (as well as 2_0_7) because of the following
error:
2007-03-22 12:57:16,391 ERROR [XSLTResult.java:365] : Unable to render XSLT
Template, 'nofile.xsl'
javax.xml.transform.TransformerException: Stylesheet nofile.xsl not found in
resources.
Maybe I am doing something wrong - first time I tried to build s2 myself.
Am Donnerstag, 22. März 2007 schrieb James Mitchell:
> Does XW trunk build for anyone else? When I try to build with Maven,
> it fails on a few tests, but if I run those same tests within
> Eclipse, they pass fine.
>
>
> --
> James Mitchell
> The Ruby Roundup
> http://www.rubyroundup.com/
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Nate Drake <nd...@gmail.com>.
I've had that funky package name problem as well.
On 3/31/07, James Mitchell <jm...@gmail.com> wrote:
> Great! I can almost build again with Maven.
>
> The problem (for me) now is with this ...
>
>
> ...
> ...
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-javadoc-plugin</artifactId>
> <executions>
> <execution>
> <id>attach-source</id>
> <goals>
> <goal>jar</goal>
> </goals>
> </execution>
> </executions>
> <configuration>
> <sourcepath>src/java</sourcepath>
> <encoding>UTF-8</encoding>
> <groups>
> <group>
> <title>XWork Packages</title>
> <packages>com.opensymphony.xwork2*</
> packages>
> </group>
> </groups>
> <show>private</show>
> <links>
> <link>http://java.sun.com/j2se/1.5.0/docs/
> api</link>
> <link>http://java.sun.com/javaee/5/docs/api/
> </link>
> <link>http://struts.apache.org/2.x/struts2-
> core/apidocs</link>
> <link>http://jakarta.apache.org/commons/
> logging/apidocs/</link>
> <link>http://logging.apache.org/log4j/docs/
> api/</link>
> </links>
> </configuration>
> </plugin>
> ...
> ...
>
>
> When I remove it, everything builds fine, but with it, I get the
> following ...
>
> ...
> ...
> [INFO] [jar:jar]
> [INFO] Building jar: /Users/jmitchell/svn/struts/xwork/target/
> xwork-2.1-SNAPSHOT.jar
> [INFO] Preparing javadoc:jar
> [WARNING] Removing: jar from forked lifecycle, to prevent recursive
> invocation.
> [INFO] No goals needed for project - skipping
> [INFO] [javadoc:jar {execution: attach-source}]
> Loading source files for package
> itchell.svn.struts.xwork.src.java.com.opensymphony.xwork2...
> Loading source files for package
> itchell.svn.struts.xwork.src.java.com.opensymphony.xwork2.config...
> (more of the same)
>
>
> The interesting part is "for package
> itchell.svn.struts.xwork.src.java.com...."
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Not sure what would cause this. Probably a Maven plugin bug.
>
>
> --
> James Mitchell
> http://jamesmitchell.us
>
>
> On Mar 31, 2007, at 5:39 AM, Claus Ibsen wrote:
>
> > Okay fixed the last broken test. All now passes in trunk and 2.0
> > branch.
> > ---------------------------------------------------------------------
> > Posted via Jive Forums
> > http://forums.opensymphony.com/thread.jspa?
> > threadID=72225&messageID=137590#137590
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Also comitted to the 2.0 branch, rev 1427.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=137835#137835
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
James.
I'll fix it shortly. Just remove the sourcepath tag from the pom.
I didn't want to mess to much with the pom file since I am rather new to maven and how you guys have setup the maven build for xwork. When I was active we used Ant.
And why is the javadoc set to show private also? Shouldn't it just be protected? I'll create a new thread about this to get more attention.
James the pom is comitted, rev 1426.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=137834#137834
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by James Mitchell <jm...@gmail.com>.
Great! I can almost build again with Maven.
The problem (for me) now is with this ...
...
...
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<executions>
<execution>
<id>attach-source</id>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
<configuration>
<sourcepath>src/java</sourcepath>
<encoding>UTF-8</encoding>
<groups>
<group>
<title>XWork Packages</title>
<packages>com.opensymphony.xwork2*</
packages>
</group>
</groups>
<show>private</show>
<links>
<link>http://java.sun.com/j2se/1.5.0/docs/
api</link>
<link>http://java.sun.com/javaee/5/docs/api/
</link>
<link>http://struts.apache.org/2.x/struts2-
core/apidocs</link>
<link>http://jakarta.apache.org/commons/
logging/apidocs/</link>
<link>http://logging.apache.org/log4j/docs/
api/</link>
</links>
</configuration>
</plugin>
...
...
When I remove it, everything builds fine, but with it, I get the
following ...
...
...
[INFO] [jar:jar]
[INFO] Building jar: /Users/jmitchell/svn/struts/xwork/target/
xwork-2.1-SNAPSHOT.jar
[INFO] Preparing javadoc:jar
[WARNING] Removing: jar from forked lifecycle, to prevent recursive
invocation.
[INFO] No goals needed for project - skipping
[INFO] [javadoc:jar {execution: attach-source}]
Loading source files for package
itchell.svn.struts.xwork.src.java.com.opensymphony.xwork2...
Loading source files for package
itchell.svn.struts.xwork.src.java.com.opensymphony.xwork2.config...
(more of the same)
The interesting part is "for package
itchell.svn.struts.xwork.src.java.com...."
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Not sure what would cause this. Probably a Maven plugin bug.
--
James Mitchell
http://jamesmitchell.us
On Mar 31, 2007, at 5:39 AM, Claus Ibsen wrote:
> Okay fixed the last broken test. All now passes in trunk and 2.0
> branch.
> ---------------------------------------------------------------------
> Posted via Jive Forums
> http://forums.opensymphony.com/thread.jspa?
> threadID=72225&messageID=137590#137590
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Okay fixed the last broken test. All now passes in trunk and 2.0 branch.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=137590#137590
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Fixed 3 out of 4 failed tests.
Comitted to trunk and the 2.0 branch.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=137587#137587
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
I'll be out of town for a few days but will commit the fixes for xwork in trunk and the 2.0x branch.
(the one with OgnlValueStackTest)
However the last failed test with the alias interceptor is still open at the moment. If anyone knows how to fix? Details posted in prev post.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=136109#136109
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Only one failing test left.
Failed tests:
testUsingDefaultInterceptorThatAliasPropertiesAreCopied(com.opensymphony.xwork2.interceptor.AliasInterceptorTest)
Tests run: 518, Failures: 1, Errors: 0, Skipped: 0
-------------------------------------------------------------------------------
Test set: com.opensymphony.xwork2.interceptor.AliasInterceptorTest
-------------------------------------------------------------------------------
Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.078 sec <<< FAILURE!
testUsingDefaultInterceptorThatAliasPropertiesAreCopied(com.opensymphony.xwork2.interceptor.AliasInterceptorTest) Time elapsed: 0.062 sec <<< FAILURE!
Error setting expression 'aliases' with value '#{ "aliasSource" : "aliasDest", "bar":"baz" }' - [unknown location]
at com.opensymphony.xwork2.util.OgnlValueStack.setValue(OgnlValueStack.java:171)
at com.opensymphony.xwork2.util.OgnlValueStack.setValue(OgnlValueStack.java:146)
at com.opensymphony.xwork2.interceptor.StaticParametersInterceptor.intercept(StaticParametersInterceptor.java:97)
at com.opensymphony.xwork2.DefaultActionInvocation$2.doProfiling(DefaultActionInvocation.java:219)
at com.opensymphony.xwork2.DefaultActionInvocation$2.doProfiling(DefaultActionInvocation.java:218)
at com.opensymphony.xwork2.util.profiling.UtilTimerStack.profile(UtilTimerStack.java:455)
at com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:216)
at com.opensymphony.xwork2.DefaultActionProxy.execute(DefaultActionProxy.java:133)
at com.opensymphony.xwork2.interceptor.AliasInterceptorTest.testUsingDefaultInterceptorThatAliasPropertiesAreCopied(AliasInterceptorTest.java:45)
<action name="aliasTest" class="com.opensymphony.xwork2.SimpleAction">
<param name="foo">17</param>
<param name="bar">23</param>
<param name="aliases">#{ "aliasSource" : "aliasDest", "bar":"baz" }</param>
<interceptor-ref name="defaultStack"/>
<interceptor-ref name="alias"/>
<result name="success" type="mock" />
</action>
Looks like trouble setting the map using OGNL.
#{ "aliasSource" : "aliasDest", "bar":"baz"
Anyone knows why? I havent tracked the latest OGNL and XWork changes.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135765#135765
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
James did you specify version 2.3 in the pom.xml to use the one that works?
The pom.xml in the svn does not specify this.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135764#135764
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by James Mitchell <jm...@gmail.com>.
Yes, that's exactly what I've been seeing.
--
James Mitchell
The Ruby Roundup
http://www.rubyroundup.com/
On Mar 25, 2007, at 7:57 AM, Claus Ibsen wrote:
> Great news.
>
> I was using Maven 2.05 vanilla. The surefire plugin in this dist is
> buggy.
> (*) Would be nice if maven could report if there are never plugins
> released that you could use.
>
> Well I upgraded to v2.3 of the surefire plugin and it now executes
> all the tests.
>
> Before:
> Tests run: 168, Failures: 0, Errors: 0, Skipped: 0
>
> After:
> Tests run: 518, Failures: 4, Errors: 0, Skipped: 0
>
> And there are 4 failed tests:
>
> Failed tests:
> testTypeConversionError
> (com.opensymphony.xwork2.util.OgnlValueStackTest)
> testNoExceptionInSetForDefault
> (com.opensymphony.xwork2.util.OgnlValueStackTest)
> testObjectSettingWithInvalidValueDoesNotCauseSetCalledWithNull
> (com.opensymphony.xwork2.util.OgnlValueStackTest)
> testUsingDefaultInterceptorThatAliasPropertiesAreCopied
> (com.opensymphony.xwork2.interceptor.AliasInterceptorTest)
>
>
> PS: The other bug in the TEST XML files are fixed in v2.3
> ---------------------------------------------------------------------
> Posted via Jive Forums
> http://forums.opensymphony.com/thread.jspa?
> threadID=72225&messageID=135713#135713
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Got 3 out of 4 failed tested fixed now.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135717#135717
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Great news.
I was using Maven 2.05 vanilla. The surefire plugin in this dist is buggy.
(*) Would be nice if maven could report if there are never plugins released that you could use.
Well I upgraded to v2.3 of the surefire plugin and it now executes all the tests.
Before:
Tests run: 168, Failures: 0, Errors: 0, Skipped: 0
After:
Tests run: 518, Failures: 4, Errors: 0, Skipped: 0
And there are 4 failed tests:
Failed tests:
testTypeConversionError(com.opensymphony.xwork2.util.OgnlValueStackTest)
testNoExceptionInSetForDefault(com.opensymphony.xwork2.util.OgnlValueStackTest)
testObjectSettingWithInvalidValueDoesNotCauseSetCalledWithNull(com.opensymphony.xwork2.util.OgnlValueStackTest)
testUsingDefaultInterceptorThatAliasPropertiesAreCopied(com.opensymphony.xwork2.interceptor.AliasInterceptorTest)
PS: The other bug in the TEST XML files are fixed in v2.3
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135713#135713
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
James can you look in the corresponding TEST- XML fille. It's this file that has additional tests in the bag.
The plain .txt file is correct. Also on my system.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135694#135694
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by James Mitchell <jm...@gmail.com>.
When I run it, here's what's in my ActionContextTest.txt
------------------------------------------------------------------------
-------
Test set: com.opensymphony.xwork2.ActionContextTest
------------------------------------------------------------------------
-------
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015
sec
You aren't seeing that?
--
James Mitchell
The Ruby Roundup
http://www.rubyroundup.com/
On Mar 24, 2007, at 10:20 AM, Claus Ibsen wrote:
> Is it just me or is surefire not a bit strange on the xwork project?
>
> Could you try this:
>
> mvn clean
> mvn surefire-report:report
>
> And then look in target/site/surefire-report.html. Then click on
> the first test - ActionContextTest.
> It should have only 8 tests. but the list is much bigger on my
> report, probably about 60-80 tests.
> It looks like it's tests from other unit tests classes got mixed in.
>
> It's also wrong in the TEST-xxxx.xml files in the target/surefire-
> reports folder.
> ---------------------------------------------------------------------
> Posted via Jive Forums
> http://forums.opensymphony.com/thread.jspa?
> threadID=72225&messageID=135519#135519
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Damm surefire seems to be a bit buggy. Just browsed it's JIRA.
Created a minor bug: http://jira.codehaus.org/browse/SUREFIRE-312
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135529#135529
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork build failing
Posted by Claus Ibsen <fo...@opensymphony.com>.
Is it just me or is surefire not a bit strange on the xwork project?
Could you try this:
mvn clean
mvn surefire-report:report
And then look in target/site/surefire-report.html. Then click on the first test - ActionContextTest.
It should have only 8 tests. but the list is much bigger on my report, probably about 60-80 tests.
It looks like it's tests from other unit tests classes got mixed in.
It's also wrong in the TEST-xxxx.xml files in the target/surefire-reports folder.
---------------------------------------------------------------------
Posted via Jive Forums
http://forums.opensymphony.com/thread.jspa?threadID=72225&messageID=135519#135519
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org