You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2023/01/18 20:16:26 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7296: Traffic Portal configuration option for Delivery Service active flags

ocket8888 opened a new pull request, #7296:
URL: https://github.com/apache/trafficcontrol/pull/7296

   This PR adds a new configuration option for Traffic Portal that allows exposing the new DS Active flag states. Disabled by default.
   
   <hr/>
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   Set `exposeInactive` in the Traffic Portal Properties file to `false` and `true` and make sure each respective behavior works as expected.
   
   ## PR submission checklist
   - [x] This PR doesn't need tests
   - [x] This PR doesn't have documentation because TP configuration options are not documented
   - [x] This PR has a CHANGELOG.md entry
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] mitchell852 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on PR #7296:
URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397194147

   Can you help me understand what this does @ocket8888 ?
   
   exposeInactive = true will display 3 options? active, primed, AND inactive
   exposeInactive = false will display 2 options? active, primed but NOT inactive
   
   ^^ is that correct?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] ocket8888 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on PR #7296:
URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397356383

   The old notion of "inactive" is what is known as "primed" in APIv5. True "INACTIVE" is not available prior to that version, so when `exposeInactive` is `true`, it'll show all three Active States, and when it's `false` it'll show ACTIVE and PRIMED - but PRIMED will be labeled "Inactive".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] rimashah25 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

Posted by GitBox <gi...@apache.org>.
rimashah25 commented on PR #7296:
URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397342010

   > Can you help me understand what this does @ocket8888 ?
   > 
   > exposeInactive = true will display 3 options? active, primed, AND inactive exposeInactive = false will display 2 options? active, primed but NOT inactive
   > 
   > ^^ is that correct?
   
   While reviewing and testing, this is what I noticed:
   `exposeInactive`=true, displays 
   ![image](https://user-images.githubusercontent.com/22248619/213515386-269b7d9e-c19b-435d-ae55-4c48f8dca997.png)
   `exposeInactive`=falise displays 
   ![image](https://user-images.githubusercontent.com/22248619/213515530-54948314-e28a-4077-9d46-6e0af5e5f00b.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] zrhoffman merged pull request #7296: Traffic Portal configuration option for Delivery Service active flags

Posted by GitBox <gi...@apache.org>.
zrhoffman merged PR #7296:
URL: https://github.com/apache/trafficcontrol/pull/7296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] mitchell852 commented on pull request #7296: Traffic Portal configuration option for Delivery Service active flags

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on PR #7296:
URL: https://github.com/apache/trafficcontrol/pull/7296#issuecomment-1397448779

   @ocket8888 - arent there a bunch of DS tables as well that will still say "primed"?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org