You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/21 21:03:43 UTC

[GitHub] [pulsar-helm-chart] toneill818 opened a new pull request #238: Cert Fix

toneill818 opened a new pull request #238:
URL: https://github.com/apache/pulsar-helm-chart/pull/238


   ### Motivation
   
   In the scripts folder there is a script to install [cert-manager 1.5.4](https://cert-manager.io/v1.5-docs/usage/certificate/), but the chart's templates do not work with that version.
   
   ### Modifications
   
   - Moved `keyAlgorithm`, `keySize`, and `keyEncoding` under the `privateKey` object
   - Moved `organization` under subject and renamed to `organizations`
   - Bumped Chart Version
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] toneill818 commented on pull request #238: Cert Fix

Posted by GitBox <gi...@apache.org>.

toneill818 commented on pull request #238:
URL: https://github.com/apache/pulsar-helm-chart/pull/238#issuecomment-1054526089


   @lhotari That works for me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] toneill818 closed pull request #238: Cert Fix

Posted by GitBox <gi...@apache.org>.

toneill818 closed pull request #238:
URL: https://github.com/apache/pulsar-helm-chart/pull/238


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #238: Cert Fix

Posted by GitBox <gi...@apache.org>.

lhotari commented on pull request #238:
URL: https://github.com/apache/pulsar-helm-chart/pull/238#issuecomment-1054352998


   @toneill818 Thank you for the contribution. It looks like there's a similar change in #233. I created #239 to first rollback #204 changes so that we have a time to prepare a fix that makes the chart also backwards compatible. Are you fine that we continue with PR #233 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org