You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@quickstep.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/08 04:02:20 UTC
[jira] [Commented] (QUICKSTEP-36) Quickstep gives segmentation
fault when it imports table from a file that does not have access rights.
[ https://issues.apache.org/jira/browse/QUICKSTEP-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472661#comment-15472661 ]
ASF GitHub Bot commented on QUICKSTEP-36:
-----------------------------------------
GitHub user tarunbansal opened a pull request:
https://github.com/apache/incubator-quickstep/pull/99
QUICKSTEP-36 Quickstep gives segmentation fault when it imports table from a file that does not have access rights.
This PR fixes QUICKSTEP-36
- Perform access check on a file before opening it to import a table.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tarunbansal/incubator-quickstep master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit b2d2534843edad1014520f8d7b5245350827d09f
Author: Tarun Bansal <ta...@gmail.com>
Date: 2016-09-07T04:40:28Z
QUICKSTEP-36 fixed.
Added read access check in TextScanOperator file before opening a file
commit b7f0ca1daf25fe930f4cf0bcf62ace234b880fe6
Author: tarunbansal <ta...@gmail.com>
Date: 2016-09-08T03:48:45Z
Added changes according to commiters workflow
----
> Quickstep gives segmentation fault when it imports table from a file that does not have access rights.
> ------------------------------------------------------------------------------------------------------
>
> Key: QUICKSTEP-36
> URL: https://issues.apache.org/jira/browse/QUICKSTEP-36
> Project: Apache Quickstep
> Issue Type: Bug
> Components: Relational Operators
> Environment: Cloudlab Instance
> Reporter: Hakan Memisoglu
> Priority: Minor
>
> When we give a file that does not exist, TextScanOperator notifies the user with an appropriate message.
> {quote}
> quickstep> COPY foo FROM '/there-is-no-such-file' WITH (DELIMITER '|');
> F0706 18:09:22.318012 8658 TextScanOperator.cpp:85] Check failed: files.size() != 0u (0 vs. 0) No files matched '/there-is-no-such-file'. Exiting.
> *** Check failure stack trace: ***
> @ 0x301b343 (unknown)
> @ 0x301b79a (unknown)
> @ 0x301ebec (unknown)
> @ 0x310ea99 (unknown)
> @ 0x305f710 (unknown)
> @ 0x305e626 (unknown)
> @ 0x305e4af (unknown)
> @ 0x305c714 (unknown)
> @ 0x302f085 (unknown)
> @ 0x7fc0e28f7350 (unknown)
> @ 0x7fc0e308e182 start_thread
> @ 0x7fc0e207f47d (unknown)
> @ (nil) (unknown)
> Aborted
> {quote}
> However, when we give a file that exist but Quickstep does not have access to it, we receive segmentation fault.
> {quote}
> quickstep> COPY foo FROM '/fastdisk/you-have-no-access.txt' WITH (DELIMITER '|');
> Segmentation fault
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)