You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/14 12:07:28 UTC

[GitHub] [incubator-seatunnel] arifgore commented on a diff in pull request #2951: [Improve][Docker]Modified Spark and Flink starter Dockerfiles

arifgore commented on code in PR #2951:
URL: https://github.com/apache/incubator-seatunnel/pull/2951#discussion_r995687252


##########
seatunnel-core/seatunnel-flink-starter/src/main/docker/Dockerfile:
##########
@@ -20,18 +20,29 @@ FROM $BASE_IMAGE
 
 ARG SCALA_VERSION
 ARG FLINK_VERSION
+ARG SEATUNNEL_VERSION
 
 RUN mkdir -p /flink ; cd /flink ; \
     tar_file=flink-${FLINK_VERSION}-bin-scala_${SCALA_VERSION}.tgz ; \
     curl -LsO https://archive.apache.org/dist/flink/flink-${FLINK_VERSION}/$tar_file ; \
     tar -zxf $tar_file --strip 1 -C . ; \
     rm $tar_file
-
+    

Review Comment:
   I don't get it. What should I revert exactly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org