You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/09/19 01:55:49 UTC
[GitHub] [rocketmq] lfz757077613 opened a new pull request, #5111: Update FileRegionEncoder.java
lfz757077613 opened a new pull request, #5111:
URL: https://github.com/apache/rocketmq/pull/5111
fix FileRegionEncoder.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5111: Update FileRegionEncoder.java
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on code in PR #5111:
URL: https://github.com/apache/rocketmq/pull/5111#discussion_r973820019
##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/FileRegionEncoder.java:
##########
@@ -52,7 +52,7 @@ protected void encode(ChannelHandlerContext ctx, FileRegion msg, final ByteBuf o
@Override
public int write(ByteBuffer src) throws IOException {
out.writeBytes(src);
- return out.capacity();
+ return src.limit() - src.position();
Review Comment:
To ensure absolute accuracy, just compare the writer index before and after
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui merged pull request #5111: Update FileRegionEncoder.java
Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #5111:
URL: https://github.com/apache/rocketmq/pull/5111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update FileRegionEncoder.java [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5111:
URL: https://github.com/apache/rocketmq/pull/5111#issuecomment-4186614635
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/5111?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 43.26%. Comparing base ([`4593793`](https://app.codecov.io/gh/apache/rocketmq/commit/45937936b88f818f3c27f04d79b59eaca14e2df0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`16d69e4`](https://app.codecov.io/gh/apache/rocketmq/commit/16d69e4ad43075e25ea738bc8cbeb6519852f338?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1641 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #5111 +/- ##
=============================================
- Coverage 43.32% 43.26% -0.06%
+ Complexity 7792 7791 -1
=============================================
Files 996 996
Lines 69230 69233 +3
Branches 9158 9159 +1
=============================================
- Hits 29995 29955 -40
- Misses 35468 35513 +45
+ Partials 3767 3765 -2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/5111?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org